Enforce variations signature verification.

chrome/browser/metrics/variations/variations_seed_store_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/variations/variations_seed_store.h"
 
 #include "base/base64.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/sha1.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "chrome/common/pref_names.h"
 #include "components/variations/proto/study.pb.h"
 #include "components/variations/proto/variations_seed.pb.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chrome_variations {
 
 namespace {
 
+class TestVariationsSeedStore : public VariationsSeedStore {
+ public:
+  explicit TestVariationsSeedStore(PrefService* local_state)
+      : VariationsSeedStore(local_state) {}
+  virtual ~TestVariationsSeedStore() {}
+
+  virtual VariationsSeedStore::VerifySignatureResult VerifySeedSignature(
+      const std::string& seed_bytes,
+      const std::string& base64_seed_signature) OVERRIDE {
+    return VariationsSeedStore::VARIATIONS_SEED_SIGNATURE_ENUM_SIZE;
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TestVariationsSeedStore);
+};
+
+
 // Populates |seed| with simple test data. The resulting seed will contain one
 // study called "test", which contains one experiment called "abc" with
 // probability weight 100. |seed|'s study field will be cleared before adding
 // the new study.
 VariationsSeed CreateTestSeed() {
   VariationsSeed seed;
   Study* study = seed.add_study();
   study->set_name("test");
   study->set_default_experiment_name("abc");
   Study_Experiment* experiment = study->add_experiment();
@@ skipping 34 matching lines @@
 TEST(VariationsSeedStoreTest, LoadSeed) {
   // Store good seed data to test if loading from prefs works.
   const VariationsSeed seed = CreateTestSeed();
   std::string seed_hash;
   const std::string base64_seed = SerializeSeedBase64(seed, &seed_hash);
 
   TestingPrefServiceSimple prefs;
   VariationsSeedStore::RegisterPrefs(prefs.registry());
   prefs.SetString(prefs::kVariationsSeed, base64_seed);
 
-  VariationsSeedStore seed_store(&prefs);
+  TestVariationsSeedStore seed_store(&prefs);
 
   VariationsSeed loaded_seed;
   // Check that loading a seed without a hash pref set works correctly.
   EXPECT_TRUE(seed_store.LoadSeed(&loaded_seed));
 
   // Check that the loaded data is the same as the original.
   EXPECT_EQ(SerializeSeed(seed), SerializeSeed(loaded_seed));
   // Make sure the pref hasn't been changed.
   EXPECT_FALSE(PrefHasDefaultValue(prefs, prefs::kVariationsSeed));
   EXPECT_EQ(base64_seed, prefs.GetString(prefs::kVariationsSeed));
 
   // Check that loading a seed with the correct hash works.
   prefs.SetString(prefs::kVariationsSeedHash, seed_hash);
   loaded_seed.Clear();
   EXPECT_TRUE(seed_store.LoadSeed(&loaded_seed));
   EXPECT_EQ(SerializeSeed(seed), SerializeSeed(loaded_seed));
 
-  // Check that false is returned and the pref is cleared when hash differs.
-  VariationsSeed different_seed = seed;
-  different_seed.mutable_study(0)->set_name("octopus");
-  std::string different_hash;
-  prefs.SetString(prefs::kVariationsSeed,
-                  SerializeSeedBase64(different_seed, &different_hash));
-  ASSERT_NE(different_hash, prefs.GetString(prefs::kVariationsSeedHash));
-  EXPECT_FALSE(PrefHasDefaultValue(prefs, prefs::kVariationsSeed));
-  EXPECT_FALSE(seed_store.LoadSeed(&loaded_seed));
-  EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeed));
-  EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedDate));
-  EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedHash));
-  EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedSignature));
-
   // Check that loading a bad seed returns false and clears the pref.
   prefs.ClearPref(prefs::kVariationsSeed);
   prefs.SetString(prefs::kVariationsSeed, "this should fail");
   EXPECT_FALSE(PrefHasDefaultValue(prefs, prefs::kVariationsSeed));
   EXPECT_FALSE(seed_store.LoadSeed(&loaded_seed));
   EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeed));
   EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedDate));
-  EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedHash));
   EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeedSignature));
 
   // Check that having no seed in prefs results in a return value of false.
   prefs.ClearPref(prefs::kVariationsSeed);
   EXPECT_FALSE(seed_store.LoadSeed(&loaded_seed));
 }
 
 TEST(VariationsSeedStoreTest, StoreSeedData) {
   const base::Time now = base::Time::Now();
   const VariationsSeed seed = CreateTestSeed();
   const std::string serialized_seed = SerializeSeed(seed);
 
   TestingPrefServiceSimple prefs;
   VariationsSeedStore::RegisterPrefs(prefs.registry());
 
-  VariationsSeedStore seed_store(&prefs);
+  TestVariationsSeedStore seed_store(&prefs);
 
   EXPECT_TRUE(seed_store.StoreSeedData(serialized_seed, std::string(), now));
   // Make sure the pref was actually set.
   EXPECT_FALSE(PrefHasDefaultValue(prefs, prefs::kVariationsSeed));
 
   std::string loaded_serialized_seed = prefs.GetString(prefs::kVariationsSeed);
   std::string decoded_serialized_seed;
   ASSERT_TRUE(base::Base64Decode(loaded_serialized_seed,
                                  &decoded_serialized_seed));
   // Make sure the stored seed from pref is the same as the seed we created.
   EXPECT_EQ(serialized_seed, decoded_serialized_seed);
 
   // Check if trying to store a bad seed leaves the pref unchanged.
   prefs.ClearPref(prefs::kVariationsSeed);
   EXPECT_FALSE(seed_store.StoreSeedData("should fail", std::string(), now));
   EXPECT_TRUE(PrefHasDefaultValue(prefs, prefs::kVariationsSeed));
 }
 
 }  // namespace chrome_variations