[DevTools] SourceFrame implements Search interface

SourceFrame implements Search interface
SourceFrame should now implement Search interface.

BUG=597431
R=lushnikov

Committed: https://crrev.com/b7c77495ebdbc0f96dd6cd92341e7c1c08a1c5e3
Cr-Commit-Position: refs/heads/master@{#383183}

[allada, 2016-03-23 23:04:33]

PTL

https://codereview.chromium.org/1830003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
(right):

https://codereview.chromium.org/1830003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js:513:
this._searchView = sourceFrame;
These are still in place to ensure if current sourceFrame has not been searched
yet (ie: performSearch() has not been executed on it) and jumpToNext (or
previous) was executed on it, it will search it for the first time instead of
trying to jumpToNext when there is no searchData sent to the sourceFrame (ie: it
wouldn't know what to search).

[allada, 2016-03-24 00:05:44]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 00:06:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830003002/20001

[commit-bot: I haz the power, 2016-03-24 02:17:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 02:17:12]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-03-24 04:02:15]

Nice! Just a few nits.

Please, add the "DevTools: " prefix to the issue title.
The title should also be separated with a new line from the issue body.

https://codereview.chromium.org/1830003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
(right):

https://codereview.chromium.org/1830003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js:32: *
@implements {WebInspector.Searchable}
we sort these in alphabet order. Please fix this whole annotation:

@constructor ..
@extends ..
@implements ..
@param ..

[allada, 2016-03-24 19:16:12]

Description was changed from

==========
SourceFrame implements Search interface
SourceFrame should now implement Search interface.

BUG=597431
R=lushnikov
==========

to

==========
SourceFrame implements Search interface
SourceFrame should now implement Search interface.

BUG=597431
R=lushnikov
==========

[allada, 2016-03-24 19:38:53]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 19:39:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830003002/40001

[allada, 2016-03-24 19:40:13]

PTL

https://codereview.chromium.org/1830003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
(right):

https://codereview.chromium.org/1830003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js:32: *
@implements {WebInspector.Searchable}
On 2016/03/24 04:02:15, lushnikov wrote:
> we sort these in alphabet order. Please fix this whole annotation:
> 
> @constructor ..
> @extends ..
> @implements ..
> @param ..

Done.

[commit-bot: I haz the power, 2016-03-24 22:11:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 22:11:25]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-03-24 23:13:51]

thanks! LGTM

nit: you should add a prefix to the body as well..

[Allada-Google, 2016-03-24 23:15:20]

The CQ bit was checked by allada@google.com

[commit-bot: I haz the power, 2016-03-24 23:15:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830003002/40001

[commit-bot: I haz the power, 2016-03-24 23:23:01]

Description was changed from

==========
SourceFrame implements Search interface
SourceFrame should now implement Search interface.

BUG=597431
R=lushnikov
==========

to

==========
SourceFrame implements Search interface
SourceFrame should now implement Search interface.

BUG=597431
R=lushnikov
==========

[commit-bot: I haz the power, 2016-03-24 23:23:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-24 23:25:01]

Description was changed from

==========
SourceFrame implements Search interface
SourceFrame should now implement Search interface.

BUG=597431
R=lushnikov
==========

to

==========
SourceFrame implements Search interface
SourceFrame should now implement Search interface.

BUG=597431
R=lushnikov

Committed: https://crrev.com/b7c77495ebdbc0f96dd6cd92341e7c1c08a1c5e3
Cr-Commit-Position: refs/heads/master@{#383183}
==========

[commit-bot: I haz the power, 2016-03-24 23:25:02]

Patchset 3 (id:??) landed as
https://crrev.com/b7c77495ebdbc0f96dd6cd92341e7c1c08a1c5e3
Cr-Commit-Position: refs/heads/master@{#383183}