Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 18300006: FileAPI: Factor out getting root URI and FS name parts into each FS backend (Closed)

Created:
7 years, 5 months ago by nhiroki
Modified:
7 years, 5 months ago
Reviewers:
kinuko, satorux1, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

FileAPI: Factor out getting root URI and FS name parts into each FS backend We plan to introduce SyncFileSystemBackend to remove SyncFS related code from webkit/browser/fileapi. To do that, this change moves getting root URI and filesystem name parts from FileSystemContext to each FileSystemBackend. BUG=242422 TEST=content_unittests R=kinuko@chromium.org, satorux@chromium.org, tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211318

Patch Set 1 : #

Messages

Total messages: 7 (0 generated)
nhiroki
Hi, can you review this? If looks good to you, I'll ask owners to review.
7 years, 5 months ago (2013-07-10 06:10:41 UTC) #1
kinuko
lgtm
7 years, 5 months ago (2013-07-10 06:18:10 UTC) #2
tzik
lgtm
7 years, 5 months ago (2013-07-10 08:33:24 UTC) #3
nhiroki
Hi satoru-san, Can you review c/b/chromeos/fileapi/file_system_backend.cc as an owner? Thanks!
7 years, 5 months ago (2013-07-10 08:50:37 UTC) #4
satorux1
hrome/browser/chromeos/fileapi/file_system_backend.cc lgtm
7 years, 5 months ago (2013-07-12 01:44:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/18300006/2001
7 years, 5 months ago (2013-07-12 02:21:16 UTC) #6
nhiroki
7 years, 5 months ago (2013-07-12 03:50:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r211318 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698