Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: src/platform-win32.cc

Issue 18300003: Fix stack alignment corruption for MinGW32 build (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-assembler-ia32.cc » ('j') | test/cctest/test-assembler-ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform-win32.cc
diff --git a/src/platform-win32.cc b/src/platform-win32.cc
index 191376099ce9b6f3c4c4873a17d076645f68572e..6671f5eb1b54c3c6ccfbb68aa8fc5a5ab5b8aab1 100644
--- a/src/platform-win32.cc
+++ b/src/platform-win32.cc
@@ -1479,9 +1479,12 @@ double OS::nan_value() {
int OS::ActivationFrameAlignment() {
#ifdef _WIN64
return 16; // Windows 64-bit ABI requires the stack to be 16-byte aligned.
-#else
- return 8; // Floating-point math runs faster with 8-byte alignment.
+#elif defined(__MINGW32__)
+ // With gcc 4.4 the tree vectorization optimizer can generate code
+ // that requires 16 byte alignment such as movdqa on x86.
+ return 16;
#endif
Jakob Kummerow 2013/07/02 15:24:18 Let's use an #else here, and keep the #endif at th
+ return 8; // Floating-point math runs faster with 8-byte alignment.
}
« no previous file with comments | « no previous file | test/cctest/test-assembler-ia32.cc » ('j') | test/cctest/test-assembler-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698