Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1829993003: Revert of Switch SkColorFilterImageFilter over to new onFilterImage interface (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Switch SkColorFilterImageFilter over to new onFilterImage interface (patchset #5 id:80001 of https://codereview.chromium.org/1782083002/ ) Reason for revert: seems to be breaking the 10k skp bot Original issue's description: > Switch SkColorFilterImageFilter over to new onFilterImage interface > > TBR=bsalomon@google.com > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1782083002 > > Committed: https://skia.googlesource.com/skia/+/ec950c4d215c6141b31b98ed6a8182a97baeb8b9 TBR=senorblanco@google.com,senorblanco@chromium.org,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/eac3e96fddca9bef9cd8cff914fd64de4877c53c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -37 lines) Patch
M include/effects/SkColorFilterImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 3 chunks +27 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Switch SkColorFilterImageFilter over to new onFilterImage interface
4 years, 9 months ago (2016-03-23 23:37:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829993003/1
4 years, 9 months ago (2016-03-23 23:38:01 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 23:38:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/eac3e96fddca9bef9cd8cff914fd64de4877c53c

Powered by Google App Engine
This is Rietveld 408576698