Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 1829993002: Move passwords and password exceptions list into a sub page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-router' is a simple router for settings. Its responsibilities: 7 * 'settings-router' is a simple router for settings. Its responsibilities:
8 * - Update the URL when the routing state changes. 8 * - Update the URL when the routing state changes.
9 * - Initialize the routing state with the initial URL. 9 * - Initialize the routing state with the initial URL.
10 * - Process and validate all routing state changes. 10 * - Process and validate all routing state changes.
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 subpage: ['bluetooth-add-device'], 308 subpage: ['bluetooth-add-device'],
309 }, 309 },
310 { 310 {
311 url: '/bluetoothAddDevice/bluetoothPairDevice', 311 url: '/bluetoothAddDevice/bluetoothPairDevice',
312 page: 'advanced', 312 page: 'advanced',
313 section: 'bluetooth', 313 section: 'bluetooth',
314 subpage: ['bluetooth-add-device', 'bluetooth-pair-device'], 314 subpage: ['bluetooth-add-device', 'bluetooth-pair-device'],
315 }, 315 },
316 </if> 316 </if>
317 { 317 {
318 url: '/passwords',
319 page: 'advanced',
320 section: 'passwordsAndForms',
321 subpage: ['manage-passwords'],
322 },
323 {
318 url: '/languages', 324 url: '/languages',
319 page: 'advanced', 325 page: 'advanced',
320 section: 'languages', 326 section: 'languages',
321 subpage: ['manage-languages'], 327 subpage: ['manage-languages'],
322 }, 328 },
323 { 329 {
324 url: '/languages/edit', 330 url: '/languages/edit',
325 page: 'advanced', 331 page: 'advanced',
326 section: 'languages', 332 section: 'languages',
327 subpage: ['language-detail'], 333 subpage: ['language-detail'],
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
403 window.history.replaceState(historicState, document.title); 409 window.history.replaceState(historicState, document.title);
404 } 410 }
405 411
406 return; 412 return;
407 } 413 }
408 } 414 }
409 415
410 assertNotReached('Route not found: ' + JSON.stringify(newRoute)); 416 assertNotReached('Route not found: ' + JSON.stringify(newRoute));
411 }, 417 },
412 }); 418 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698