Add the ability for DevTools to wrap network transactions.

net/http/http_cache.h

Index: net/http/http_cache.h
diff --git a/net/http/http_cache.h b/net/http/http_cache.h
index dd9d0cdfcae36cfcbff10cbbeacc6874179768c9..250f81ce4fe3463f3f154632b72e9d305a6533f9 100644
--- a/net/http/http_cache.h
+++ b/net/http/http_cache.h
@@ -138,7 +138,8 @@ class NET_EXPORT HttpCache : public HttpTransactionFactory,
   // destroyed.
   HttpCache(HttpTransactionFactory* network_layer,

[rvargas (doing something else), 2014/04/29 23:40:45]

This constructor is intended for unit tests but it seems like now it is used
from production code. At the very least the comment is now stale, but more
importantly, it would be nice to not increase the numbers of ways to initialize
this class.

[eustas, 2014/05/07 13:47:17]

It is possible to remove constructor that takes params and backend.
It is referenced from 5 locations.

Also I can remove all references from tests to this constructor (because tests
can use SetHttpNetworkTransactionFactoryForTesting
to substitute network layer).

Just let me know I'll be glad to address it in separate patch.

[rvargas (doing something else), 2014/05/07 20:22:57]

I don't have an issue with tests using the same constructor that is used by
production code.

What we have today is two constructors that are used from Chrome so I would
prefer to not increase that number.

             NetLog* net_log,
-            BackendFactory* backend_factory);
+            BackendFactory* backend_factory,
+            bool setup_network_session);

[rvargas (doing something else), 2014/04/29 23:40:45]

It is not clear how a caller should know what to pass here.

[eustas, 2014/05/07 13:47:17]

Reverted.

 
   virtual ~HttpCache();
 
@@ -354,6 +355,10 @@ class NET_EXPORT HttpCache : public HttpTransactionFactory,
   bool RemovePendingTransactionFromPendingOp(PendingOp* pending_op,
                                              Transaction* trans);
 
+  // Instantiates and sets QUIC server info factory. Should be invoked only
+  // once for every network session.
+  void SetupNetworkSession(HttpNetworkSession* session);

[rvargas (doing something else), 2014/04/29 23:40:45]

If what this does is to configure quick server info, it may be better to use a
name that reflects that. SetupNetworkSession is kind of vague and it's not clear
why we'll end up with a valid |session| that has not been setup.

[eustas, 2014/05/07 13:47:17]

Done.

+
   // Resumes processing the pending list of |entry|.
   void ProcessPendingQueue(ActiveEntry* entry);
 
@@ -389,7 +394,7 @@ class NET_EXPORT HttpCache : public HttpTransactionFactory,
 
   Mode mode_;
 
-  const scoped_ptr<QuicServerInfoFactoryAdaptor> quic_server_info_factory_;
+  scoped_ptr<QuicServerInfoFactoryAdaptor> quic_server_info_factory_;
 
   scoped_ptr<HttpTransactionFactory> network_layer_;