Add the ability for DevTools to wrap network transactions.

content/public/browser/content_browser_client.h

Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index ac40ae2cd57e1655844c604f5a40a7442db8f6e2..a57d72a153dda7eeb6a3ab554e2a03d1ed54a7c3 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -539,6 +539,12 @@ class CONTENT_EXPORT ContentBrowserClient {
   // Clears browser cookies.
   virtual void ClearCookies(RenderViewHost* rvh) {}
 
+  // Disables / reenables network. |id| should be DevToolsAgentHost GUID.
+  virtual void DisableNetwork(

[jochen (gone - plz use gerrit), 2014/04/23 09:42:07]

Can we come up with a more descriptive name?

It's only disabling the network if disable == true, right? And what is the
relation to the RenderViewHost? Is it supposed to only disable networking for
that RVH?

[eustas, 2014/04/23 12:33:08]

Surely, but I got stuck choosing name...
Here are some thoughts:

EnableNetwork (sounds better, but less intuitive)

EmulateNetworkConnectivityLoss

SetNetworkEmulationConfiguration (and pass struct, that contain User-Agent
overrides, etc.)


Network is disabled for Profile (BrowserContext); network is disabled if there
is at least one client that requested it.

RVH is used to access BrowserContext.

[jochen (gone - plz use gerrit), 2014/04/23 12:39:29]

I think I like that one.

Or SetNetworkState() or similar if you don't want to go for the struct right
away.
hum, why isn't the method on BrowserContext then? Or ResourceContext even since
apparently most of the work is done on the io thread anyway?

[jam, 2014/04/23 19:48:30]

+1: ContentBrowserClient is a last resort embedder API, when there's no other
context to call stuff on. we haven't been diligent on ensuring this; but now i'm
trying to in other cls. so please, instead of calling CBC with a BrowserContext
so that chrome translates to a ResourceContext and then calls a method on the IO
thread, just call a ResourceContext method directly from content.

+      RenderViewHost* rvh,
+      const std::string& id,

[jochen (gone - plz use gerrit), 2014/04/23 09:42:07]

maybe devtools_client_id?

[eustas, 2014/04/23 12:33:08]

devtools_client_id would be confusing.

For now I'll change it simply to client_id.

I'll change it to devtools_agent_id if you like.

+      bool disable) {}
+
   // Returns the default download directory.
   // This can be called on any thread.
   virtual base::FilePath GetDefaultDownloadDirectory();