Add the ability for DevTools to wrap network transactions.

net/http/http_cache.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file declares a HttpTransactionFactory implementation that can be
 // layered on top of another HttpTransactionFactory to add HTTP caching.  The
 // caching logic follows RFC 2616 (any exceptions are called out in the code).
 //
 // The HttpCache takes a disk_cache::Backend as a parameter, and uses that for
 // the cache storage.
@@ skipping 118 matching lines @@
   // Provide an existing HttpNetworkSession, the cache can construct a
   // network layer with a shared HttpNetworkSession in order for multiple
   // network layers to share information (e.g. authentication data). The
   // HttpCache takes ownership of the |backend_factory|.
   HttpCache(HttpNetworkSession* session, BackendFactory* backend_factory);
 
   // Initialize the cache from its component parts, which is useful for
   // testing.  The lifetime of the network_layer and backend_factory are managed
   // by the HttpCache and will be destroyed using |delete| when the HttpCache is
   // destroyed.
   HttpCache(HttpTransactionFactory* network_layer,

[rvargas (doing something else), 2014/04/29 23:40:45]

This constructor is intended for unit tests but it seems like now it is used
from production code. At the very least the comment is now stale, but more
importantly, it would be nice to not increase the numbers of ways to initialize
this class.

[eustas, 2014/05/07 13:47:17]

It is possible to remove constructor that takes params and backend.
It is referenced from 5 locations.

Also I can remove all references from tests to this constructor (because tests
can use SetHttpNetworkTransactionFactoryForTesting
to substitute network layer).

Just let me know I'll be glad to address it in separate patch.

[rvargas (doing something else), 2014/05/07 20:22:57]

I don't have an issue with tests using the same constructor that is used by
production code.

What we have today is two constructors that are used from Chrome so I would
prefer to not increase that number.

             NetLog* net_log,
-            BackendFactory* backend_factory);
+            BackendFactory* backend_factory,
+            bool setup_network_session);

[rvargas (doing something else), 2014/04/29 23:40:45]

It is not clear how a caller should know what to pass here.

[eustas, 2014/05/07 13:47:17]

Reverted.

 
   virtual ~HttpCache();
 
   HttpTransactionFactory* network_layer() { return network_layer_.get(); }
 
   // Retrieves the cache backend for this HttpCache instance. If the backend
   // is not initialized yet, this method will initialize it. The return value is
   // a network error code, and it could be ERR_IO_PENDING, in which case the
   // |callback| will be notified when the operation completes. The pointer that
   // receives the |backend| must remain valid until the operation completes.
@@ skipping 195 matching lines @@
   void RemovePendingTransaction(Transaction* trans);
 
   // Removes the transaction |trans|, from the pending list of |entry|.
   bool RemovePendingTransactionFromEntry(ActiveEntry* entry,
                                          Transaction* trans);
 
   // Removes the transaction |trans|, from the pending list of |pending_op|.
   bool RemovePendingTransactionFromPendingOp(PendingOp* pending_op,
                                              Transaction* trans);
 
+  // Instantiates and sets QUIC server info factory. Should be invoked only
+  // once for every network session.
+  void SetupNetworkSession(HttpNetworkSession* session);

[rvargas (doing something else), 2014/04/29 23:40:45]

If what this does is to configure quick server info, it may be better to use a
name that reflects that. SetupNetworkSession is kind of vague and it's not clear
why we'll end up with a valid |session| that has not been setup.

[eustas, 2014/05/07 13:47:17]

Done.

+
   // Resumes processing the pending list of |entry|.
   void ProcessPendingQueue(ActiveEntry* entry);
 
   // Events (called via PostTask) ---------------------------------------------
 
   void OnProcessPendingQueue(ActiveEntry* entry);
 
   // Callbacks ----------------------------------------------------------------
 
   // Processes BackendCallback notifications.
@@ skipping 15 matching lines @@
   // Variables ----------------------------------------------------------------
 
   NetLog* net_log_;
 
   // Used when lazily constructing the disk_cache_.
   scoped_ptr<BackendFactory> backend_factory_;
   bool building_backend_;
 
   Mode mode_;
 
-  const scoped_ptr<QuicServerInfoFactoryAdaptor> quic_server_info_factory_;
+  scoped_ptr<QuicServerInfoFactoryAdaptor> quic_server_info_factory_;
 
   scoped_ptr<HttpTransactionFactory> network_layer_;
 
   scoped_ptr<disk_cache::Backend> disk_cache_;
 
   // The set of active entries indexed by cache key.
   ActiveEntriesMap active_entries_;
 
   // The set of doomed entries.
   ActiveEntriesSet doomed_entries_;
 
   // The set of entries "under construction".
   PendingOpsMap pending_ops_;
 
   scoped_ptr<PlaybackCacheMap> playback_cache_map_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpCache);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_CACHE_H_