Add the ability for DevTools to wrap network transactions.

chrome/browser/devtools/devtools_network_controller_unittest.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "chrome/browser/devtools/devtools_network_controller.h"
+#include "chrome/browser/devtools/devtools_network_transaction.h"
+#include "net/http/http_transaction_unittest.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
+
+namespace {

[mmenke, 2014/04/18 15:41:42]

nit:  Blank line after namespace, and before end of namespace.

[eustas, 2014/04/21 11:34:59]

Done.

+  class TestCallback {
+   public:
+    TestCallback() : run_count_(0), value_(0) {}
+    void Run(int value) {
+      run_count_++;
+      value_ = value;
+    }
+    int run_count() { return run_count_; }
+    int value() { return value_; }
+   private:

[mmenke, 2014/04/18 15:41:42]

nit:  Blank line before private.

[eustas, 2014/04/21 11:34:59]

Done.

+    int run_count_;
+    int value_;
+  };
+
+  class TransactionHelper {
+   public:
+    TransactionHelper() :
+        completion_callback_(
+            base::Bind(&TestCallback::Run, base::Unretained(&callback_))),
+        mock_transaction_(kSimpleGET_Transaction),
+        buffer_(new net::IOBuffer(64)) {
+      mock_transaction_.test_mode = TEST_MODE_SYNC_NET_START;
+      mock_transaction_.url = "http://dot.com";
+      AddMockTransaction(&mock_transaction_);
+
+      scoped_ptr<net::HttpTransaction> network_transaction;
+      network_layer_.CreateTransaction(
+          net::DEFAULT_PRIORITY, &network_transaction);
+      transaction_.reset(new DevToolsNetworkTransaction(
+          &controller_, network_transaction.Pass()));
+    }
+
+    int Start() {
+        MockHttpRequest request(mock_transaction_);
+        return transaction_->Start(
+            &request, completion_callback_, net::BoundNetLog());
+    }
+
+    int Read() {
+      return transaction_->Read(buffer_.get(), 64, completion_callback_);
+    }
+
+    ~TransactionHelper() {
+      RemoveMockTransaction(&mock_transaction_);
+    }
+
+    TestCallback* callback() { return &callback_; }
+    MockTransaction* mock_transaction() { return &mock_transaction_; }
+    DevToolsNetworkController* controller() { return &controller_; }
+    DevToolsNetworkTransaction* transaction() { return transaction_.get(); }
+
+   private:
+    base::MessageLoop message_loop_;
+    MockNetworkLayer network_layer_;
+    TestCallback callback_;
+    net::CompletionCallback completion_callback_;
+    MockTransaction mock_transaction_;
+    DevToolsNetworkController controller_;
+    scoped_ptr<DevToolsNetworkTransaction> transaction_;
+    scoped_refptr<net::IOBuffer> buffer_;

[mmenke, 2014/04/18 15:41:42]

Include ref_counted.h

[eustas, 2014/04/21 11:34:59]

Done.

+  };
+} // namespace

[mmenke, 2014/04/18 15:41:42]

nit:  2 spaces between code and comment.

[mmenke, 2014/04/18 15:41:42]

Couldn't this go at the end of the file?

[eustas, 2014/04/21 11:34:59]

Done.

[eustas, 2014/04/21 11:34:59]

I can split definition/declaration, but this won't make a huge difference - only
20 lines out of 60 could be moved. Unfortunately, cpp wants fully defined
classes when we address their members.

+
+TEST(DevToolsNetworkControllerTest, SingleDisableEnable) {
+  TransactionHelper helper;
+  DevToolsNetworkController* controller = helper.controller();
+  DevToolsNetworkTransaction* transaction = helper.transaction();
+  std::string test_id = "42";
+  helper.Start();
+
+  EXPECT_FALSE(controller->ShouldFail(transaction));
+  controller->DisableNetwork(test_id, true);
+  EXPECT_TRUE(controller->ShouldFail(transaction));
+  controller->DisableNetwork(test_id, false);
+  EXPECT_FALSE(controller->ShouldFail(transaction));
+}
+
+TEST(DevToolsNetworkControllerTest, DoubleDisableEnable) {
+  TransactionHelper helper;
+  DevToolsNetworkController* controller = helper.controller();
+  DevToolsNetworkTransaction* transaction = helper.transaction();
+  std::string test_id_1 = "42";
+  std::string test_id_2 = "24";
+  helper.Start();
+
+  EXPECT_FALSE(controller->ShouldFail(transaction));
+  controller->DisableNetwork(test_id_1, true);
+  EXPECT_TRUE(controller->ShouldFail(transaction));
+  controller->DisableNetwork(test_id_2, true);
+  EXPECT_TRUE(controller->ShouldFail(transaction));
+  controller->DisableNetwork(test_id_1, false);
+  EXPECT_TRUE(controller->ShouldFail(transaction));
+  controller->DisableNetwork(test_id_2, false);
+  EXPECT_FALSE(controller->ShouldFail(transaction));
+}
+
+TEST(DevToolsNetworkControllerTest, FailOnStart) {
+  TransactionHelper helper;
+  helper.controller()->DisableNetwork("42", true);
+
+  int rv = helper.Start();
+  EXPECT_EQ(rv, net::ERR_INTERNET_DISCONNECTED);
+
+  base::RunLoop().RunUntilIdle();
+  EXPECT_EQ(helper.callback()->run_count(), 0);
+}
+
+TEST(DevToolsNetworkControllerTest, FailRunningTransaction) {
+  TransactionHelper helper;
+  DevToolsNetworkController* controller = helper.controller();
+  TestCallback* callback = helper.callback();
+  std::string test_id = "42";
+
+  int rv = helper.Start();
+  EXPECT_EQ(rv, net::OK);
+
+  scoped_refptr<net::IOBuffer> buffer(new net::IOBuffer(64));
+  rv = helper.Read();
+  EXPECT_EQ(rv, net::ERR_IO_PENDING);
+  EXPECT_EQ(callback->run_count(), 0);
+
+  controller->DisableNetwork(test_id, true);
+  EXPECT_EQ(callback->run_count(), 1);
+  EXPECT_EQ(callback->value(), net::ERR_INTERNET_DISCONNECTED);
+
+  base::RunLoop().RunUntilIdle();
+  EXPECT_EQ(callback->run_count(), 1);
+
+  // Check that transaction in not failed second time.
+  controller->DisableNetwork(test_id, false);
+  controller->DisableNetwork(test_id, true);
+  EXPECT_EQ(callback->run_count(), 1);
+}
+
+TEST(DevToolsNetworkControllerTest, BypassDevToolsRequests) {
+  TransactionHelper helper;
+  helper.mock_transaction()->request_headers =
+      "X-DevTools-Request-Initiator: frontend\r\n";
+  DevToolsNetworkController* controller = helper.controller();
+  DevToolsNetworkTransaction* transaction = helper.transaction();
+  helper.Start();
+
+  EXPECT_FALSE(controller->ShouldFail(transaction));
+  controller->DisableNetwork("42", true);
+  EXPECT_FALSE(controller->ShouldFail(transaction));
+}