Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h

Issue 1829923004: Do not set m_decodeFailed in ImageFrameGenerator::decodeToYUV (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: back to PS1, add a new m_yuvDecodingFailed Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 108
109 SkISize m_fullSize; 109 SkISize m_fullSize;
110 110
111 // ThreadSafeDataTransport is referenced by this class and m_encodedData. 111 // ThreadSafeDataTransport is referenced by this class and m_encodedData.
112 // In case that ImageFrameGenerator get's deleted before m_encodedData, 112 // In case that ImageFrameGenerator get's deleted before m_encodedData,
113 // m_encodedData would hold the reference to it (and underlying data). 113 // m_encodedData would hold the reference to it (and underlying data).
114 RefPtr<ThreadSafeDataTransport> m_data; 114 RefPtr<ThreadSafeDataTransport> m_data;
115 115
116 bool m_isMultiFrame; 116 bool m_isMultiFrame;
117 bool m_decodeFailed; 117 bool m_decodeFailed;
118 bool m_yuvDecodingFailed;
118 size_t m_frameCount; 119 size_t m_frameCount;
119 Vector<bool> m_hasAlpha; 120 Vector<bool> m_hasAlpha;
120 121
121 class ExternalMemoryAllocator; 122 class ExternalMemoryAllocator;
122 OwnPtr<ExternalMemoryAllocator> m_externalAllocator; 123 OwnPtr<ExternalMemoryAllocator> m_externalAllocator;
123 124
124 OwnPtr<ImageDecoderFactory> m_imageDecoderFactory; 125 OwnPtr<ImageDecoderFactory> m_imageDecoderFactory;
125 126
126 // Prevents multiple decode operations on the same data. 127 // Prevents multiple decode operations on the same data.
127 Mutex m_decodeMutex; 128 Mutex m_decodeMutex;
128 129
129 // Protect concurrent access to m_hasAlpha. 130 // Protect concurrent access to m_hasAlpha.
130 Mutex m_alphaMutex; 131 Mutex m_alphaMutex;
131 132
132 // Our encoded image data returned in refEncodedData. 133 // Our encoded image data returned in refEncodedData.
133 SkData* m_encodedData; 134 SkData* m_encodedData;
134 135
135 #if COMPILER(MSVC) 136 #if COMPILER(MSVC)
136 friend struct ::WTF::OwnedPtrDeleter<ExternalMemoryAllocator>; 137 friend struct ::WTF::OwnedPtrDeleter<ExternalMemoryAllocator>;
137 #endif 138 #endif
138 }; 139 };
139 140
140 } // namespace blink 141 } // namespace blink
141 142
142 #endif 143 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698