Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1829923003: [Android,RemotePlayback] Resolve HTMLMediaElement.remote.connect() with false when device is not se… (Closed)

Created:
4 years, 9 months ago by whywhat
Modified:
4 years, 8 months ago
CC:
avayvod+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, mlamouri+watch-media_chromium.org, philipj_slow, posciak+watch_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@remote-playback-connect
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android,RemotePlayback] Resolve HTMLMediaElement.remote.connect() with false when device is not selected. BUG=578833 TEST=manual Committed: https://crrev.com/94711d0ac1303d5799a8ff04789e20423e73a05c Cr-Commit-Position: refs/heads/master@{#384309}

Patch Set 1 #

Patch Set 2 : Fixed some spaces #

Patch Set 3 : Fixed desktop unittests compile #

Patch Set 4 : Rebased #

Patch Set 5 : Another rebase #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaRouteChooserDialogFactory.java View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaRouteController.java View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java View 1 2 3 4 5 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/media/android/remote/remote_media_player_bridge.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/media/android/remote/remote_media_player_bridge.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/media/android/remote/remote_media_player_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/media/android/remote/remote_media_player_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/media/media_player_messages_android.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/renderer_media_player_interface.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/webmediaplayer_cast_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/webmediaplayer_cast_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayerClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/remoteplayback/WebRemotePlaybackClient.h View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 33 (12 generated)
whywhat
Fixed some spaces
4 years, 9 months ago (2016-03-23 21:38:34 UTC) #1
whywhat
PTaL, mostly straightforward plumbing from RemoteMediaPlayerBridge to HTMLMediaElement philipj: HTMLMediaElement.*, WebMediaPlayerClient.h, */remoteplayback/* dalecurtis: media/blink/*, content/renderer/media/android/* ...
4 years, 9 months ago (2016-03-23 21:41:31 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829923003/20001
4 years, 9 months ago (2016-03-23 21:42:13 UTC) #5
DaleCurtis
me => hubbe
4 years, 9 months ago (2016-03-23 21:49:18 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/177336) mac_chromium_rel_ng on ...
4 years, 9 months ago (2016-03-23 21:56:24 UTC) #9
whywhat
Fixed desktop unittests compile
4 years, 9 months ago (2016-03-23 22:35:19 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829923003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829923003/40001
4 years, 9 months ago (2016-03-23 22:38:39 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/20951)
4 years, 9 months ago (2016-03-23 23:08:30 UTC) #14
philipj_slow
third_party/WebKit/ LGTM
4 years, 9 months ago (2016-03-24 07:27:15 UTC) #15
whywhat
Rebased
4 years, 9 months ago (2016-03-24 16:10:58 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829923003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829923003/60001
4 years, 9 months ago (2016-03-24 16:11:46 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/177648)
4 years, 9 months ago (2016-03-24 16:25:48 UTC) #20
whywhat
Another rebase
4 years, 9 months ago (2016-03-24 16:48:46 UTC) #21
nasko
media_player_messages_android.h LGTM
4 years, 9 months ago (2016-03-24 21:27:58 UTC) #22
hubbe
lgtm
4 years, 9 months ago (2016-03-24 21:42:56 UTC) #23
aberent
lgtm
4 years, 8 months ago (2016-03-29 14:51:30 UTC) #24
whywhat
Thanks all for the reviews!
4 years, 8 months ago (2016-03-29 18:38:09 UTC) #26
whywhat
Rebased
4 years, 8 months ago (2016-03-31 10:58:39 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829923003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829923003/100001
4 years, 8 months ago (2016-03-31 15:52:06 UTC) #30
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-03-31 16:57:17 UTC) #31
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 17:02:01 UTC) #33
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/94711d0ac1303d5799a8ff04789e20423e73a05c
Cr-Commit-Position: refs/heads/master@{#384309}

Powered by Google App Engine
This is Rietveld 408576698