Issue 1829893002: Formatter: Avoid extraneous empty lines at the end of a block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1829893002: Formatter: Avoid extraneous empty lines at the end of a block. (Closed)

Created:
4 years, 9 months ago by azani

Modified:
4 years, 9 months ago

Reviewers:
rudominer

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Formatter: Avoid extraneous empty lines at the end of a block. R=rudominer@chromium.org, rudominer BUG= #592 Committed: https://chromium.googlesource.com/external/mojo/+/7eaac248e7e90630ed3012ca02adb75d1f461382

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -5 lines)			Patch
M	mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1	View	2	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1	View	2	1 chunk	+1 line, -1 line	0 comments	Download
M	mojom/mojom_parser/formatter/formatter_test.go	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	mojom/mojom_parser/formatter/printer.go	View		2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

azani

4 years, 9 months ago (2016-03-23 20:47:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
7eaac248e7e90630ed3012ca02adb75d1f461382 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages