Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1829883002: Add index-8 sampler to the pipeline. (Closed)

Created:
4 years, 9 months ago by herb_g
Modified:
4 years, 9 months ago
Reviewers:
f(malita), mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Align sk4f array for win32. #

Patch Set 3 : Fix MSVC again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -44 lines) Patch
M src/core/SkBitmapProcShader.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/core/SkLinearBitmapPipeline.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkLinearBitmapPipeline.cpp View 2 chunks +14 lines, -1 line 0 comments Download
M src/core/SkLinearBitmapPipeline_sample.h View 1 2 14 chunks +127 lines, -38 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829883002/1
4 years, 9 months ago (2016-03-23 19:11:38 UTC) #5
herb_g
4 years, 9 months ago (2016-03-23 19:11:45 UTC) #6
herb_g
4 years, 9 months ago (2016-03-23 19:12:49 UTC) #7
reed1
lgtm https://codereview.chromium.org/1829883002/diff/1/src/core/SkLinearBitmapPipeline.cpp File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1829883002/diff/1/src/core/SkLinearBitmapPipeline.cpp#newcode570 src/core/SkLinearBitmapPipeline.cpp:570: alphaType = kUnpremul_SkAlphaType; // This throws away opaqueness. ...
4 years, 9 months ago (2016-03-23 19:17:27 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/7343)
4 years, 9 months ago (2016-03-23 19:17:31 UTC) #10
herb_g
Align sk4f array for win32.
4 years, 9 months ago (2016-03-23 20:44:27 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829883002/20001
4 years, 9 months ago (2016-03-23 20:45:12 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/7353) Build-Win-MSVC-x86_64-Debug-Trybot on ...
4 years, 9 months ago (2016-03-23 20:52:42 UTC) #15
herb_g
Fix MSVC again.
4 years, 9 months ago (2016-03-23 21:56:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829883002/40001
4 years, 9 months ago (2016-03-23 21:56:46 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 22:14:27 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/222f8ff12914d71e439de84df57de6550e09098e

Powered by Google App Engine
This is Rietveld 408576698