net/base/host_port_pair_unittest.cc - Issue 1829873002: Add base/parse_number.h to generalize number parsing done in //net.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/host_port_pair_unittest.cc

Issue 1829873002: Add base/parse_number.h to generalize number parsing done in //net. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/host_port_pair_unittest.cc

diff --git a/net/base/host_port_pair_unittest.cc b/net/base/host_port_pair_unittest.cc

index 8047cc3181401dffd0cc917b90969bf58e1aacb9..72704a0f5c908ec15422ca1098e19805e70a9997 100644

--- a/net/base/host_port_pair_unittest.cc

+++ b/net/base/host_port_pair_unittest.cc

@@ -38,11 +38,8 @@ TEST(HostPortPairTest, Parsing) {

TEST(HostPortPairTest, BadString) {

const char* kBadStrings[] = {

- "foo.com:2:3",

- "bar.com:two",

- "www.google.com:-1",

- "127.0.0.1:65536",

- "[2001:db8::42]:65536",

+ "foo.com:2:3", "bar.com:two", "www.google.com:-1",

+ "www.google.com:+1", "127.0.0.1:65536", "[2001:db8::42]:65536",

};

for (size_t index = 0; index < arraysize(kBadStrings); ++index) {

« no previous file with comments | « net/base/host_port_pair.cc ('k') | net/base/ip_address.cc » ('j') | no next file with comments »