Add base/parse_number.h to generalize number parsing done in //net.

net/base/parse_number.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This file contains utility functions for parsing numbers, in the context of
+// network protocols.
+//
+// Q: Doesn't //base already provide these in string_number_conversions.h, with
+//    functions like base::StringToInt()?
+//
+// A: Yes, and those functions are used under the hood by these
+//    implementations.
+//
+//    However using the number parsing functions from //base directly in network
+//    code can lead to subtle bugs, as the //base versions  are more permissive.
+//    For instance "+99" is successfully parsed by base::StringToInt().
+//
+//    However in the majority of places in //net, a leading plus on a number
+//    should be considered invalid. For instance when parsing a host:port pair
+//    you wouldn't want to recognize "foo:+99" as having a port of 99. The same
+//    issue applies when parsing a content-length header.
+//
+//    To reduce the risk of such problems, use of these functions over the
+//    //base versions.

[mmenke, 2016/03/23 19:32:28]

Mind putting these under the includes?  I know that I, at least, always miss
comments up here.  When scrolling in a file, I see the includes, and think I'm
at the top.

[eroman, 2016/03/23 19:50:30]

Done, I agree with finding it there hard.

However technically I believe that is a violation of the google C++ guide:

https://google.github.io/styleguide/cppguide.html#File_Comments

[mmenke, 2016/03/23 20:12:06]

I dunno...This doesn't describe the contents of the license boilerplate.  Surely
that's what "it" refers to "Start each file with license boilerplate, followed
by a description of its contents.", so I think we're good.  :)

+
+#ifndef NET_BASE_PARSE_NUMBER_H_
+#define NET_BASE_PARSE_NUMBER_H_
+
+#include "base/compiler_specific.h"
+#include "base/strings/string_piece.h"

[mmenke, 2016/03/23 19:32:28]

Forward declare this, and include it in the CC file?

[eroman, 2016/03/23 19:50:30]

StringPiece I believe can't (easily) be forward declared as it uses template
magic.
Do you have suggestions on how to do it?

The code I have come across gives up and just includes the header.

And some (inconsistent on exact pattern) code passes by value so necessarily
needs the definition.

[mmenke, 2016/03/23 20:12:06]

I'm afraid I don't.  StringPiece looks so nice and fluffy...I hadn't thought of
the template horror that lurks just beneath the surface.

+#include "net/base/net_export.h"
+
+class GURL;
+
+namespace net {
+
+//  Parses a string representing a decimal number to an |int|. Returns true on
+//  success, and fills |*output| with the result. Note that  |*output| is not
+//  modified on failure.
+//
+//  Recognized inputs take the form:
+//    1*DIGIT
+//
+//  Where DIGIT is an ASCII number in the range '0' - '9'
+//
+//  Note that:
+//   * Parsing is locale independent
+//   * Leading zeros are allowed (numbers needn't be in minimal encoding)
+//   * Inputs that would overflow the output are rejected.
+//   * Only accepts integers
+//
+//  Examples of recognized inputs are:
+//    "13"
+//    "0"
+//    "00013"
+//
+//  Examples of rejected inputs are:
+//    "  13"
+//    "-13"
+//    "+13"
+//    "0x15"
+//    "13.3"
+NET_EXPORT bool ParseNonNegativeDecimalInt(const base::StringPiece& input,

[eroman, 2016/03/23 19:15:01]

This may seem like overkill to have 1 function in 1 file....

But I expect I will need a couple lesser used overloads, for uint/int64/uint64
variations so this will grow by the time I am done solving the bug.

Also the documentation is pretty dense.

[mmenke, 2016/03/23 19:32:28]

I think this is reasonable.

+                                           int* output) WARN_UNUSED_RESULT;

[eroman, 2016/03/23 19:15:01]

WARN_UNUSED_RESULT is also a modification over the //base API, since I have seen
some sketchy looking usages in //net where we don't check for success.

+
+}  // namespace net
+
+#endif  // NET_BASE_PARSE_NUMBER_H_