[V8] Add v8::Value::TypeOf to API

[V8] Add v8::Value::TypeOf to API

There is TypeOf static method on object inside V8. In this CL I've extracted it via API.

LOG=Y
R=yangguo@chromium.org
BUG=chromium:595206
Committed: https://crrev.com/6f419dfe6796296c3e944faac2f3724198b4062f
Cr-Commit-Position: refs/heads/master@{#36113}

[kozy, 2016-03-23 17:52:51]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 17:53:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829833002/1

[kozy, 2016-03-23 17:53:20]

Yang, please take a look!
We need this method to move some of our JS code in InjectedScriptSource.js to
native.

[commit-bot: I haz the power, 2016-03-23 18:18:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 18:18:21]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-03-24 05:25:37]

yangguo@chromium.org changed reviewers:
+ jochen@chromium.org

[Yang, 2016-03-24 05:25:37]

LGTM. But it would be great if you could wait for Jochen to give this API change
a look.

[jochen (gone - plz use gerrit), 2016-03-24 14:49:40]

https://codereview.chromium.org/1829833002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1829833002/diff/1/include/v8.h#newcode2042
include/v8.h:2042: static V8_WARN_UNUSED_RESULT MaybeLocal<String> TypeOf(
why is this static?

[kozy, 2016-03-24 15:58:57]

https://codereview.chromium.org/1829833002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1829833002/diff/1/include/v8.h#newcode2042
include/v8.h:2042: static V8_WARN_UNUSED_RESULT MaybeLocal<String> TypeOf(
On 2016/03/24 14:49:39, jochen - slow wrote:
> why is this static?

There is no big reason. Changed to member.

[jochen (gone - plz use gerrit), 2016-03-30 16:15:13]

https://codereview.chromium.org/1829833002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1829833002/diff/20001/src/api.cc#newcode3522
src/api.cc:3522: has_pending_exception = result.is_null();
sorry for not catching this earlier, but as far as I can tell, result can never
be null.

[kozy, 2016-05-06 17:01:46]

Patchset #3 (id:40001) has been deleted

[kozy, 2016-05-06 17:03:01]

Description was changed from

==========
[V8] Add v8::Value::TypeOf to API

There is TypeOf static method on object inside V8. In this CL I've extracted it
via API.

LOG=Y
R=yangguo@chromium.org
==========

to

==========
[V8] Add v8::Value::TypeOf to API

There is TypeOf static method on object inside V8. In this CL I've extracted it
via API.

LOG=Y
R=yangguo@chromium.org
BUG=chromium:595206
==========

[kozy, 2016-05-06 17:03:13]

all done, please take a look

https://codereview.chromium.org/1829833002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1829833002/diff/20001/src/api.cc#newcode3522
src/api.cc:3522: has_pending_exception = result.is_null();
On 2016/03/30 16:15:13, jochen wrote:
> sorry for not catching this earlier, but as far as I can tell, result can
never
> be null. 

Rewritten without PREPATE_FOR_EXECUTION

[Yang, 2016-05-09 05:23:28]

On 2016/05/06 17:03:13, kozyatinskiy wrote:
> all done, please take a look
> 
> https://codereview.chromium.org/1829833002/diff/20001/src/api.cc
> File src/api.cc (right):
> 
> https://codereview.chromium.org/1829833002/diff/20001/src/api.cc#newcode3522
> src/api.cc:3522: has_pending_exception = result.is_null();
> On 2016/03/30 16:15:13, jochen wrote:
> > sorry for not catching this earlier, but as far as I can tell, result can
> never
> > be null. 
> 
> Rewritten without PREPATE_FOR_EXECUTION

LGTM

[jochen (gone - plz use gerrit), 2016-05-09 15:28:18]

lgtm

[kozy, 2016-05-09 15:37:48]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-05-09 15:37:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829833002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829833002/60001

[commit-bot: I haz the power, 2016-05-09 16:21:02]

Description was changed from

==========
[V8] Add v8::Value::TypeOf to API

There is TypeOf static method on object inside V8. In this CL I've extracted it
via API.

LOG=Y
R=yangguo@chromium.org
BUG=chromium:595206
==========

to

==========
[V8] Add v8::Value::TypeOf to API

There is TypeOf static method on object inside V8. In this CL I've extracted it
via API.

LOG=Y
R=yangguo@chromium.org
BUG=chromium:595206
==========

[commit-bot: I haz the power, 2016-05-09 16:21:04]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-09 16:21:44]

Description was changed from

==========
[V8] Add v8::Value::TypeOf to API

There is TypeOf static method on object inside V8. In this CL I've extracted it
via API.

LOG=Y
R=yangguo@chromium.org
BUG=chromium:595206
==========

to

==========
[V8] Add v8::Value::TypeOf to API

There is TypeOf static method on object inside V8. In this CL I've extracted it
via API.

LOG=Y
R=yangguo@chromium.org
BUG=chromium:595206

Committed: https://crrev.com/6f419dfe6796296c3e944faac2f3724198b4062f
Cr-Commit-Position: refs/heads/master@{#36113}
==========

[commit-bot: I haz the power, 2016-05-09 16:21:45]

Patchset 3 (id:??) landed as
https://crrev.com/6f419dfe6796296c3e944faac2f3724198b4062f
Cr-Commit-Position: refs/heads/master@{#36113}