src/effects/SkDropShadowImageFilter.cpp - Issue 182983003: Factory methods for heap-allocated SkImageFilter objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkDropShadowImageFilter.cpp

Issue 182983003: Factory methods for heap-allocated SkImageFilter objects. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: typo Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkDropShadowImageFilter.cpp

diff --git a/src/effects/SkDropShadowImageFilter.cpp b/src/effects/SkDropShadowImageFilter.cpp

index 6d68a24d43b86d718e928ee24608760c41494b60..7c9631c3935ebcfaabe53dc52ff9d32a4af4ce88 100644

--- a/src/effects/SkDropShadowImageFilter.cpp

+++ b/src/effects/SkDropShadowImageFilter.cpp

@@ -82,7 +82,7 @@ bool SkDropShadowImageFilter::onFilterImage(Proxy* proxy, const SkBitmap& source

matrix.mapVectors(&sigma, &localSigma, 1);

sigma.fX = SkMaxScalar(0, sigma.fX);

sigma.fY = SkMaxScalar(0, sigma.fY);

- SkAutoTUnref<SkImageFilter> blurFilter(new SkBlurImageFilter(sigma.fX, sigma.fY));

+ SkAutoTUnref<SkImageFilter> blurFilter(SkBlurImageFilter::Create(sigma.fX, sigma.fY));

SkAutoTUnref<SkColorFilter> colorFilter(SkColorFilter::CreateModeFilter(fColor, SkXfermode::kSrcIn_Mode));

SkPaint paint;

paint.setImageFilter(blurFilter.get());