tests/GLProgramsTest.cpp - Issue 182983003: Factory methods for heap-allocated SkImageFilter objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/GLProgramsTest.cpp

Issue 182983003: Factory methods for heap-allocated SkImageFilter objects. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/GLProgramsTest.cpp

diff --git a/tests/GLProgramsTest.cpp b/tests/GLProgramsTest.cpp

index e63342c936456117043bdaf6ca0b5f4628cad037..3df08a7f5b59f031119248218f29dd643b810b83 100644

--- a/tests/GLProgramsTest.cpp

+++ b/tests/GLProgramsTest.cpp

@@ -257,7 +257,8 @@ void forceLinking();

void forceLinking() {

SkLightingImageFilter::CreateDistantLitDiffuse(SkPoint3(0,0,0), 0, 0, 0);

SkAlphaThresholdFilter::Create(SkRegion(), .5f, .5f);

- SkMagnifierImageFilter mag(SkRect::MakeWH(SK_Scalar1, SK_Scalar1), SK_Scalar1);

+ SkAutoTUnref<SkMagnifierImageFilter> mag(SkMagnifierImageFilter::Create(

+ SkRect::MakeWH(SK_Scalar1, SK_Scalar1), SK_Scalar1));

GrConfigConversionEffect::Create(NULL,

false,

GrConfigConversionEffect::kNone_PMConversion,

« no previous file with comments | « src/effects/SkPictureImageFilter.cpp ('k') | tests/ImageFilterTest.cpp » ('j') | no next file with comments »