Factory methods for heap-allocated SkImageFilter objects.

include/effects/SkPictureImageFilter.h

 /*
  * Copyright 2013 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkPictureImageFilter_DEFINED
 #define SkPictureImageFilter_DEFINED
 
 #include "SkImageFilter.h"
 #include "SkPicture.h"
 
 class SK_API SkPictureImageFilter : public SkImageFilter {
 public:
     /**
      *  Refs the passed-in picture.
      */
-    explicit SkPictureImageFilter(SkPicture* picture);
+    static SkPictureImageFilter* Create(SkPicture* picture) {
+        return SkNEW_ARGS(SkPictureImageFilter, (picture));
+    }
 
     /**
      *  Refs the passed-in picture. rect can be used to crop or expand the destination rect when
      *  the picture is drawn. (No scaling is implied by the dest rect; only the CTM is applied.)
      */
-    SkPictureImageFilter(SkPicture* picture, const SkRect& rect);
+    static SkPictureImageFilter* Create(SkPicture* picture, const SkRect& rect) {

[reed1, 2014/03/04 16:56:42]

'rect' is a pretty unmeaningful parameter name. Does it become the 'bounds' of
the src image? When creating a raster of the picture (internally) is the picture
translated by -rect.top/left and then clipped by rect?

[Stephen White, 2014/03/04 18:18:00]

Yep, it's the bounds in world space (it gets transformed by the CTM). We could
change it to cropRect like the other filters, but all its edges are mandatory
(unlike the cropRect), so that might be misleading.

[Dominik Grewe, 2014/03/07 16:43:38]

Changed it to cropRect.

+        return SkNEW_ARGS(SkPictureImageFilter, (picture, rect));
+    }
 
     SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkPictureImageFilter)
 
 protected:
     virtual ~SkPictureImageFilter();
     /*  Constructs an SkPictureImageFilter object from an SkReadBuffer.
      *  Note: If the SkPictureImageFilter object construction requires bitmap
      *  decoding, the decoder must be set on the SkReadBuffer parameter by calling
      *  SkReadBuffer::setBitmapDecoder() before calling this constructor.
      *  @param SkReadBuffer Serialized picture data.
      */
     explicit SkPictureImageFilter(SkReadBuffer&);
     virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
     virtual bool onFilterImage(Proxy*, const SkBitmap& src, const SkMatrix&,
                                SkBitmap* result, SkIPoint* offset) const SK_OVERRIDE;
 
+#ifdef SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS
+public:
+#endif
+    explicit SkPictureImageFilter(SkPicture* picture);
+    SkPictureImageFilter(SkPicture* picture, const SkRect& rect);
+
 private:
     SkPicture* fPicture;
     SkRect     fRect;
     typedef SkImageFilter INHERITED;
 };
 
 #endif