Factory methods for heap-allocated SkImageFilter objects.

include/effects/SkMagnifierImageFilter.h

 /*
  * Copyright 2012 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkMagnifierImageFilter_DEFINED
 #define SkMagnifierImageFilter_DEFINED
 
 #include "SkRect.h"
 #include "SkImageFilter.h"
 
 class SK_API SkMagnifierImageFilter : public SkImageFilter {
 public:
-    SkMagnifierImageFilter(SkRect srcRect, SkScalar inset);
+    static SkMagnifierImageFilter* Create(SkRect srcRect, SkScalar inset) {

[reed1, 2014/03/04 16:56:42]

Shouldn't this be (const SkRect& srcRect, ...) ?

[Stephen White, 2014/03/04 18:18:00]

Probably. (zork@?)

[Dominik Grewe, 2014/03/07 16:43:38]

Done (and for constructor below).

+        return SkNEW_ARGS(SkMagnifierImageFilter, (srcRect, inset));
+    }
 
     SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkMagnifierImageFilter)
 
 protected:
     explicit SkMagnifierImageFilter(SkReadBuffer& buffer);
     virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
 
     virtual bool onFilterImage(Proxy*, const SkBitmap& src, const SkMatrix&,
                                SkBitmap* result, SkIPoint* offset) const SK_OVERRIDE;
 #if SK_SUPPORT_GPU
     virtual bool asNewEffect(GrEffectRef** effect, GrTexture* texture, const SkMatrix& matrix, const SkIRect& bounds) const SK_OVERRIDE;
 #endif
 
+#ifdef SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS
+public:
+#endif
+    SkMagnifierImageFilter(SkRect srcRect, SkScalar inset);
+
 private:
     SkRect fSrcRect;
     SkScalar fInset;
     typedef SkImageFilter INHERITED;
 };
 
 #endif