Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1829753003: [Extensions] Update generated code to support movable additional properties (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Update generated code to support movable additional properties The initial pass-through missed updating "additional_properties". Fix this. BUG=595949 Committed: https://crrev.com/6446c0e591ed89ee959511dd4f1c9cb5c4290609 Cr-Commit-Position: refs/heads/master@{#383097}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Antony's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -9 lines) Patch
M tools/json_schema_compiler/cc_generator.py View 1 4 chunks +19 lines, -9 lines 0 comments Download
M tools/json_schema_compiler/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/json_schema_compiler/test/json_schema_compiler_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/json_schema_compiler/test/objects_movable.idl View 1 chunk +1 line, -0 lines 0 comments Download
A tools/json_schema_compiler/test/objects_movable_json.json View 1 chunk +18 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/test/objects_unittest.cc View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Devlin
D'oh - forgot additional_properties was a special thing. https://codereview.chromium.org/1829753003/diff/1/tools/json_schema_compiler/cc_generator.py File tools/json_schema_compiler/cc_generator.py (right): https://codereview.chromium.org/1829753003/diff/1/tools/json_schema_compiler/cc_generator.py#newcode216 tools/json_schema_compiler/cc_generator.py:216: if ...
4 years, 9 months ago (2016-03-23 21:41:01 UTC) #2
asargent_no_longer_on_chrome
lgtm https://codereview.chromium.org/1829753003/diff/1/tools/json_schema_compiler/cc_generator.py File tools/json_schema_compiler/cc_generator.py (right): https://codereview.chromium.org/1829753003/diff/1/tools/json_schema_compiler/cc_generator.py#newcode216 tools/json_schema_compiler/cc_generator.py:216: if (real_t.property_type != PropertyType.ENUM and # enums handled ...
4 years, 9 months ago (2016-03-24 17:03:57 UTC) #3
Devlin
https://codereview.chromium.org/1829753003/diff/1/tools/json_schema_compiler/cc_generator.py File tools/json_schema_compiler/cc_generator.py (right): https://codereview.chromium.org/1829753003/diff/1/tools/json_schema_compiler/cc_generator.py#newcode216 tools/json_schema_compiler/cc_generator.py:216: if (real_t.property_type != PropertyType.ENUM and # enums handled below ...
4 years, 9 months ago (2016-03-24 17:35:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829753003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829753003/20001
4 years, 9 months ago (2016-03-24 17:36:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-24 18:09:27 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 18:11:27 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6446c0e591ed89ee959511dd4f1c9cb5c4290609
Cr-Commit-Position: refs/heads/master@{#383097}

Powered by Google App Engine
This is Rietveld 408576698