Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1829723002: Move grid-template-areas into CSSPropertyParser (Closed)

Created:
4 years, 9 months ago by rwlbuis
Modified:
4 years, 8 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move grid-template-areas into CSSPropertyParser Move the grid-template-areas longhand from LegacyCSSPropertyParser into CSSPropertyParser. In order to reuse parseGridTemplateAreasRow make it work on a String parameter rather than the value list or range. BUG=499780 Committed: https://crrev.com/f717b520181da918b7ffbc65d9a7dbcf07717e00 Cr-Commit-Position: refs/heads/master@{#384277}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -38 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 2 chunks +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 4 chunks +6 lines, -36 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
rwlbuis
PTAL.
4 years, 8 months ago (2016-03-30 19:55:53 UTC) #4
Timothy Loh
lgtm https://codereview.chromium.org/1829723002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1829723002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode3236 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3236: if (!rowCount || !columnCount) Might be able to ...
4 years, 8 months ago (2016-03-31 00:22:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829723002/40001
4 years, 8 months ago (2016-03-31 02:04:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/166761)
4 years, 8 months ago (2016-03-31 02:06:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829723002/40001
4 years, 8 months ago (2016-03-31 02:30:40 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/204401)
4 years, 8 months ago (2016-03-31 03:40:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829723002/40001
4 years, 8 months ago (2016-03-31 10:41:55 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/204555)
4 years, 8 months ago (2016-03-31 12:54:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829723002/40001
4 years, 8 months ago (2016-03-31 13:45:05 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-31 14:56:17 UTC) #22
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 14:57:43 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f717b520181da918b7ffbc65d9a7dbcf07717e00
Cr-Commit-Position: refs/heads/master@{#384277}

Powered by Google App Engine
This is Rietveld 408576698