Move grid-template-areas into CSSPropertyParser

Move grid-template-areas into CSSPropertyParser

Move the grid-template-areas longhand from
LegacyCSSPropertyParser into CSSPropertyParser.

In order to reuse parseGridTemplateAreasRow make
it work on a String parameter rather than the value
list or range.

BUG=499780
Committed: https://crrev.com/f717b520181da918b7ffbc65d9a7dbcf07717e00
Cr-Commit-Position: refs/heads/master@{#384277}

[rwlbuis, 2016-03-30 19:52:21]

Description was changed from

==========
grid-template-areas WIP


grid-template WIP

BUG=
==========

to

==========
grid-template-areas WIP


grid-template WIP

BUG=

parseGridTemplateAreasRow
==========

[rwlbuis, 2016-03-30 19:54:35]

Description was changed from

==========
grid-template-areas WIP


grid-template WIP

BUG=

parseGridTemplateAreasRow
==========

to

==========
Move grid-template-areas into CSSPropertyParser

Move the grid-template-areas longhand from
LegacyCSSPropertyParser into CSSPropertyParser.

In order to reuse parseGridTemplateAreasRow make
it work on a String parameter rather than the value
list or range.

BUG=499780
==========

[rwlbuis, 2016-03-30 19:55:52]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-03-30 19:55:53]

PTAL.

[Timothy Loh, 2016-03-31 00:22:46]

lgtm

https://codereview.chromium.org/1829723002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1829723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3236: if
(!rowCount || !columnCount)
Might be able to ASSERT(columnCount) below this check instead of checking. Also
please use == 0 instead of !, this isn't WebKit :)

[rwlbuis, 2016-03-31 02:04:24]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-03-31 02:04:24]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1829723002/#ps40001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-03-31 02:04:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829723002/40001

[commit-bot: I haz the power, 2016-03-31 02:06:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 02:06:23]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[rwlbuis, 2016-03-31 02:30:05]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-03-31 02:30:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829723002/40001

[commit-bot: I haz the power, 2016-03-31 03:40:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 03:40:10]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rwlbuis, 2016-03-31 10:41:37]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-03-31 10:41:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829723002/40001

[commit-bot: I haz the power, 2016-03-31 12:54:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 12:54:48]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rwlbuis, 2016-03-31 13:44:49]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-03-31 13:45:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829723002/40001

[commit-bot: I haz the power, 2016-03-31 14:56:16]

Description was changed from

==========
Move grid-template-areas into CSSPropertyParser

Move the grid-template-areas longhand from
LegacyCSSPropertyParser into CSSPropertyParser.

In order to reuse parseGridTemplateAreasRow make
it work on a String parameter rather than the value
list or range.

BUG=499780
==========

to

==========
Move grid-template-areas into CSSPropertyParser

Move the grid-template-areas longhand from
LegacyCSSPropertyParser into CSSPropertyParser.

In order to reuse parseGridTemplateAreasRow make
it work on a String parameter rather than the value
list or range.

BUG=499780
==========

[commit-bot: I haz the power, 2016-03-31 14:56:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-31 14:57:42]

Description was changed from

==========
Move grid-template-areas into CSSPropertyParser

Move the grid-template-areas longhand from
LegacyCSSPropertyParser into CSSPropertyParser.

In order to reuse parseGridTemplateAreasRow make
it work on a String parameter rather than the value
list or range.

BUG=499780
==========

to

==========
Move grid-template-areas into CSSPropertyParser

Move the grid-template-areas longhand from
LegacyCSSPropertyParser into CSSPropertyParser.

In order to reuse parseGridTemplateAreasRow make
it work on a String parameter rather than the value
list or range.

BUG=499780

Committed: https://crrev.com/f717b520181da918b7ffbc65d9a7dbcf07717e00
Cr-Commit-Position: refs/heads/master@{#384277}
==========

[commit-bot: I haz the power, 2016-03-31 14:57:43]

Patchset 3 (id:??) landed as
https://crrev.com/f717b520181da918b7ffbc65d9a7dbcf07717e00
Cr-Commit-Position: refs/heads/master@{#384277}