src/pdf/SkPDFBitmap.h - Issue 1829693002: SkPDF: draw{Image,Bitmap} always serializes early

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFBitmap.h

Issue 1829693002: SkPDF: draw{Image,Bitmap} always serializes early (Closed) Base URL: https://skia.googlesource.com/skia.git@r1823683005

Patch Set: Don't put a sk_sp in a hashmap Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFBitmap.h

diff --git a/src/pdf/SkPDFBitmap.h b/src/pdf/SkPDFBitmap.h

index b0254c1f551fbb97b7b6bc4b7c6a2d88feabf42f..86beef31cee3ba2184940f542b23e612ff72b6a9 100644

--- a/src/pdf/SkPDFBitmap.h

+++ b/src/pdf/SkPDFBitmap.h

@@ -16,6 +16,7 @@ class SkImage;

* It is designed to use a minimal amout of memory, aside from refing

* the image, and its emitObject() does not cache any data.

-SkPDFObject* SkPDFCreateBitmapObject(const SkImage*, SkPixelSerializer*);

+sk_sp<SkPDFObject> SkPDFCreateBitmapObject(sk_sp<SkImage>,

+ SkPixelSerializer*);

#endif // SkPDFBitmap_DEFINED