Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: bench/PDFBench.cpp

Issue 1829693002: SkPDF: draw{Image,Bitmap} always serializes early (Closed) Base URL: https://skia.googlesource.com/skia.git@r1823683005
Patch Set: Don't put a sk_sp in a hashmap Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gyp/pdf.gypi » ('j') | src/pdf/SkBitmapKey.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/PDFBench.cpp
diff --git a/bench/PDFBench.cpp b/bench/PDFBench.cpp
index 75b05de29d89c6fb77037188db84779e75d8ed82..f0e0436f6eb2ca6ac0b772f64eb278d2bc4572fc 100644
--- a/bench/PDFBench.cpp
+++ b/bench/PDFBench.cpp
@@ -23,12 +23,12 @@ struct NullWStream : public SkWStream {
size_t fN;
};
-static void test_pdf_object_serialization(SkPDFObject* object) {
+static void test_pdf_object_serialization(const sk_sp<SkPDFObject> object) {
// SkDebugWStream wStream;
NullWStream wStream;
SkPDFSubstituteMap substitutes;
SkPDFObjNumMap objNumMap;
- objNumMap.addObjectRecursively(object, substitutes);
+ objNumMap.addObjectRecursively(object.get(), substitutes);
for (int i = 0; i < objNumMap.objects().count(); ++i) {
SkPDFObject* object = objNumMap.objects()[i].get();
wStream.writeDecAsText(i + 1);
@@ -64,8 +64,7 @@ protected:
return;
}
while (loops-- > 0) {
- SkAutoTUnref<SkPDFObject> object(
- SkPDFCreateBitmapObject(fImage.get(), nullptr));
+ auto object = SkPDFCreateBitmapObject(fImage, nullptr);
SkASSERT(object);
if (!object) {
return;
@@ -91,7 +90,7 @@ protected:
void onDelayedSetup() override {
sk_sp<SkImage> img(GetResourceAsImage("mandrill_512_q075.jpg"));
if (!img) { return; }
- SkAutoTUnref<SkData> encoded(img->refEncoded());
+ sk_sp<SkData> encoded(img->refEncoded());
SkASSERT(encoded);
if (!encoded) { return; }
fImage = img;
@@ -102,8 +101,7 @@ protected:
return;
}
while (loops-- > 0) {
- SkAutoTUnref<SkPDFObject> object(
- SkPDFCreateBitmapObject(fImage.get(), nullptr));
+ auto object = SkPDFCreateBitmapObject(fImage, nullptr);
SkASSERT(object);
if (!object) {
return;
@@ -135,7 +133,7 @@ protected:
SkASSERT(fAsset);
if (!fAsset) { return; }
while (loops-- > 0) {
- SkAutoTUnref<SkPDFObject> object(
+ sk_sp<SkPDFObject> object(
new SkPDFSharedStream(fAsset->duplicate()));
test_pdf_object_serialization(object);
}
« no previous file with comments | « no previous file | gyp/pdf.gypi » ('j') | src/pdf/SkBitmapKey.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698