Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Side by Side Diff: chrome/browser/banners/app_banner_debug_log.h

Issue 1829643002: App Banner: require 'display' to be set to 'standalone' or 'fullscreen'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_ 5 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_
6 #define CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_ 6 #define CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 namespace content { 10 namespace content {
11 class WebContents; 11 class WebContents;
12 } // namespace content 12 } // namespace content
13 13
14 namespace banners { 14 namespace banners {
15 15
16 // Error message strings used to notify developers via the console. 16 // Error message strings used to notify developers via the console.
17 extern const char kRendererRequestCancel[]; 17 extern const char kRendererRequestCancel[];
18 extern const char kManifestEmpty[]; 18 extern const char kManifestEmpty[];
19 extern const char kNoManifest[]; 19 extern const char kNoManifest[];
20 extern const char kCannotDetermineBestIcon[]; 20 extern const char kCannotDetermineBestIcon[];
21 extern const char kNoMatchingServiceWorker[]; 21 extern const char kNoMatchingServiceWorker[];
22 extern const char kNoIconAvailable[]; 22 extern const char kNoIconAvailable[];
23 extern const char kUserNavigatedBeforeBannerShown[]; 23 extern const char kUserNavigatedBeforeBannerShown[];
24 extern const char kStartURLNotValid[]; 24 extern const char kStartURLNotValid[];
25 extern const char kManifestMissingNameOrShortName[]; 25 extern const char kManifestMissingNameOrShortName[];
26 extern const char kManifestDisplayStandaloneFullscreen[];
26 extern const char kManifestMissingSuitableIcon[]; 27 extern const char kManifestMissingSuitableIcon[];
27 extern const char kNotLoadedInMainFrame[]; 28 extern const char kNotLoadedInMainFrame[];
28 extern const char kNotServedFromSecureOrigin[]; 29 extern const char kNotServedFromSecureOrigin[];
29 extern const char kIgnoredNotSupportedOnAndroid[]; 30 extern const char kIgnoredNotSupportedOnAndroid[];
30 extern const char kIgnoredNoId[]; 31 extern const char kIgnoredNoId[];
31 extern const char kIgnoredIdsDoNotMatch[]; 32 extern const char kIgnoredIdsDoNotMatch[];
32 33
33 // Logs a message to the main console if a banner could not be shown 34 // Logs a message to the main console if a banner could not be shown
34 // and the engagement checks have been bypassed. 35 // and the engagement checks have been bypassed.
35 void OutputDeveloperNotShownMessage(content::WebContents* web_contents, 36 void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
36 const std::string& message, 37 const std::string& message,
37 bool is_debug_mode); 38 bool is_debug_mode);
38 39
39 // Logs a debugging message to the main console if the engagement checks have 40 // Logs a debugging message to the main console if the engagement checks have
40 // been bypassed. 41 // been bypassed.
41 void OutputDeveloperDebugMessage(content::WebContents* web_contents, 42 void OutputDeveloperDebugMessage(content::WebContents* web_contents,
42 const std::string& message, 43 const std::string& message,
43 bool is_debug_mode); 44 bool is_debug_mode);
44 45
45 } // namespace banners 46 } // namespace banners
46 47
47 #endif // CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_ 48 #endif // CHROME_BROWSER_BANNERS_APP_BANNER_DEBUG_LOG_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698