Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1829583006: Reenable ServiceWorkerVersionBrowserTest.TimeoutStartingWorker (Closed)

Created:
4 years, 9 months ago by falken
Modified:
4 years, 9 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable ServiceWorkerVersionBrowserTest.TimeoutStartingWorker I suspect fixing Issue 568465 fixed this flake. BUG=496065 Committed: https://crrev.com/b5da6b9dbae869c46ded3fe00c6d12c67fd9a505 Cr-Commit-Position: refs/heads/master@{#383055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
falken
4 years, 9 months ago (2016-03-24 09:18:49 UTC) #2
nhiroki
lgtm
4 years, 9 months ago (2016-03-24 09:22:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829583006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829583006/1
4 years, 9 months ago (2016-03-24 09:34:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 12:28:38 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 12:29:49 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b5da6b9dbae869c46ded3fe00c6d12c67fd9a505
Cr-Commit-Position: refs/heads/master@{#383055}

Powered by Google App Engine
This is Rietveld 408576698