Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3413)

Unified Diff: docs/closure_compilation.md

Issue 1829553002: Closure Compiler: Add script to run compile and update Wiki docs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/closure_compiler/compiled_resources.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/closure_compilation.md
diff --git a/docs/closure_compilation.md b/docs/closure_compilation.md
index 540abf6cb4a027e7216fa99395ea843cd664d0f2..bc1cabd3c5d673f3950c21dbd4f2e1237aeb4f76 100644
--- a/docs/closure_compilation.md
+++ b/docs/closure_compilation.md
@@ -15,17 +15,10 @@ On Mac or Windows, visit:
### Using ninja to compile the code
-We use GYP and ninja as our build system. To generate the ninja files from GYP:
+To compile the JavaScript, run this script:
```shell
-# notice the 2 in compiled_resources2.gyp
-GYP_GENERATORS=ninja tools/gyp/gyp --depth . third_party/closure_compiler/compiled_resources2.gyp
-```
-
-To compile the JavaScript:
-
-```shell
-ninja -C out/Default -j4
+third_party/closure_compiler/run_compiler
```
The output should look something like this:
@@ -35,16 +28,10 @@ ninja: Entering directory `out/Default/'
[30/106] ACTION Compiling chrome/browser/resources/md_history/constants.js
```
-To generate and run the **deprecated** v1 gyp format, remove the "2" from "compiled_resources2.gyp":
-
-```shell
-$ GYP_GENERATORS=ninja tools/gyp/gyp --depth . third_party/closure_compiler/compiled_resources.gyp
-```
-
-Compiling works the same way for both v1 and v2 systems:
+To compile only a specific target, add an argument after the script name:
```shell
-ninja -C out/Default -j4
+third_party/closure_compiler/run_compiler people_page
```
## Background
« no previous file with comments | « no previous file | third_party/closure_compiler/compiled_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698