Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1829553002: Closure Compiler: Add script to run compile and update Wiki docs. (Closed)

Created:
4 years, 9 months ago by tommycli
Modified:
4 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Closure Compiler: Add script to run compile and update Wiki docs. This patch adds a script to run the Closure Compile for Chrome resources. It also updates the wiki to reflect this. BUG=596944 Committed: https://crrev.com/521de10fba02c37a5221a70a29a9e53fe478733c Cr-Commit-Position: refs/heads/master@{#383378}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M docs/closure_compilation.md View 1 2 chunks +4 lines, -17 lines 0 comments Download
M third_party/closure_compiler/compiled_resources.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_compiler/compiled_resources2.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/closure_compiler/run_compiler View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
tommycli
dbeam: PTAL wiki change
4 years, 9 months ago (2016-03-23 01:39:09 UTC) #2
Dan Beam
i think we should make a small shell script instead, then update the docs to ...
4 years, 9 months ago (2016-03-23 01:49:27 UTC) #3
tommycli
dbeam: This is just a simple script to run the compile (covers both compiled_resources and ...
4 years, 9 months ago (2016-03-25 20:38:20 UTC) #5
Dan Beam
/cc brettw@ as FYI lgtm
4 years, 9 months ago (2016-03-25 21:14:48 UTC) #6
tommycli
On 2016/03/25 21:14:48, Dan Beam wrote: > /cc brettw@ as FYI > > lgtm thanks!
4 years, 9 months ago (2016-03-25 21:15:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829553002/20001
4 years, 9 months ago (2016-03-25 21:16:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-25 22:07:27 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 22:09:50 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/521de10fba02c37a5221a70a29a9e53fe478733c
Cr-Commit-Position: refs/heads/master@{#383378}

Powered by Google App Engine
This is Rietveld 408576698