Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1829543002: [remoting android] Trim Cardboard library from APK. (Closed)

Created:
4 years, 9 months ago by Lambros
Modified:
4 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting android] Trim Cardboard library from APK. This removes the Cardboard SDK shared library, reducing the size of the APK, if remoting_enable_cardboard build flag is not set. BUG=595027 Committed: https://crrev.com/96a958a950c47965cda6ceaf9ca2990685b2e8e9 Cr-Commit-Position: refs/heads/master@{#382904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M remoting/android/remoting_apk_tmpl.gni View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/remoting_android.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Lambros
4 years, 9 months ago (2016-03-23 00:52:34 UTC) #2
Sergey Ulanov
lgtm
4 years, 9 months ago (2016-03-23 18:56:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829543002/1
4 years, 9 months ago (2016-03-23 19:00:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 19:45:32 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 19:48:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96a958a950c47965cda6ceaf9ca2990685b2e8e9
Cr-Commit-Position: refs/heads/master@{#382904}

Powered by Google App Engine
This is Rietveld 408576698