Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1829513003: OSX: Media appearance values don't support native focus ring. (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, philipj_slow, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OSX: Media appearance values don't support native focus ring. BUG=591451 Committed: https://crrev.com/bccaa6b939b3daed06d54bd99ffb1c9e24e5a8b4 Cr-Commit-Position: refs/heads/master@{#382830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/media/controls-focus-ring.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/media/controls-focus-ring-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/media/controls-focus-ring-expected.txt View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 1 chunk +24 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
tkent
Keishi, would you review this please?
4 years, 9 months ago (2016-03-23 09:38:44 UTC) #3
keishi
LGTM
4 years, 9 months ago (2016-03-23 10:44:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829513003/1
4 years, 9 months ago (2016-03-23 10:45:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 11:19:52 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 11:22:01 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bccaa6b939b3daed06d54bd99ffb1c9e24e5a8b4
Cr-Commit-Position: refs/heads/master@{#382830}

Powered by Google App Engine
This is Rietveld 408576698