Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1829513002: Use Sk4x4f in srcover_srgb_dst_1. (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use Sk4x4f in srcover_srgb_dst_1. I've also pulled out the common parts shared with sRGB srcover_n, and rearranged to make the similarities a bit more clear. This speeds up about 25%. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1829513002 Committed: https://skia.googlesource.com/skia/+/0dfe89248972f701a0a96812ffed801bcc0387b0

Patch Set 1 #

Patch Set 2 : tweaks for clarity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -73 lines) Patch
M src/core/SkXfermode4f.cpp View 1 4 chunks +67 lines, -73 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829513002/20001
4 years, 9 months ago (2016-03-23 00:25:48 UTC) #5
mtklein_C
I think this is what you were suggesting I look at next, right?
4 years, 9 months ago (2016-03-23 00:28:25 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-23 00:42:26 UTC) #9
reed1
yes, this was the place. wow, 25% is huge. great job! lgtm
4 years, 9 months ago (2016-03-23 01:27:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829513002/20001
4 years, 9 months ago (2016-03-23 01:29:45 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 01:30:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0dfe89248972f701a0a96812ffed801bcc0387b0

Powered by Google App Engine
This is Rietveld 408576698