third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp - Issue 1829493002: [SPv2] Implement CSS clip property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

Issue 1829493002: [SPv2] Implement CSS clip property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move fixedpos clip to updateOutOfFlowContext Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp ('K') | « third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

index a1a5329f86e0109dc7c1a6c068acbc3a51c097ab..60e7a0c5ad17ffe6bfd459ff0551735dfdf93a8a 100644

--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

@@ -173,7 +173,7 @@ scoped_refptr<cc::Layer> createClipLayer(const ClipPaintPropertyNode* node)

// other kinds of intermediate layers, such as those that apply effects.

// TODO(jbroman): This assumes that the transform space of this node's

// parent is an ancestor of this node's transform space. That's not

- // necessarily true, and this should be fixed.

+ // necessarily true, and this should be fixed. crbug.com/597156

gfx::Transform transform = transformToTransformSpace(localTransformSpace(node), localTransformSpace(node->parent()));

gfx::Vector2dF offset = clipRect.OffsetFromOrigin();

transform.Translate(offset.x(), offset.y());

@@ -271,6 +271,8 @@ void PaintArtifactCompositor::update(const PaintArtifact& paintArtifact)

ClipLayerManager clipLayerManager(m_rootLayer.get());

for (const PaintChunk& paintChunk : paintArtifact.paintChunks()) {

cc::Layer* parent = clipLayerManager.switchToNewClipLayer(paintChunk.properties.clip.get());

+ // TODO(jbroman): Same as above. This assumes the transform space of the current clip is

+ // an ancestor of the chunk. It is not necessarily true. crbug.com/597156

gfx::Transform transform = transformToTransformSpace(paintChunk.properties.transform.get(), localTransformSpace(paintChunk.properties.clip.get()));

scoped_refptr<cc::Layer> layer = layerForPaintChunk(paintArtifact, paintChunk, transform);

layer->SetNeedsDisplay();