Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1829463002: Issue 26063. Index declarations in even partically analyzed units. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -42 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/index.dart View 3 chunks +33 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/services/index/index_test.dart View 3 chunks +33 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/index_unit.dart View 6 chunks +50 lines, -28 lines 0 comments Download
M pkg/analyzer/test/src/summary/index_unit_test.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M pkg/analyzer/tool/summary/build_sdk_summaries.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-22 21:22:11 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-22 21:59:47 UTC) #2
scheglov
4 years, 9 months ago (2016-03-23 00:24:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e4218b7545aa8a0c0e8326771c27363d21fc8b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698