Correct png inverse gAMA when parsing color space

Correct png inverse gAMA when parsing color space

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1829433002

Committed: https://skia.googlesource.com/skia/+/128245c61d56abcacdb152ad08038c5d9c919df0

[msarett, 2016-03-22 20:42:58]

Description was changed from

==========
Correct png inverse gAMA when parsing color space

BUG=skia:
==========

to

==========
Correct png inverse gAMA when parsing color space

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-03-22 20:44:04]

msarett@google.com changed reviewers:
+ brianosman@google.com

[Brian Osman, 2016-03-23 13:01:50]

https://codereview.chromium.org/1829433002/diff/1/src/codec/SkPngCodec.cpp
File src/codec/SkPngCodec.cpp (right):

https://codereview.chromium.org/1829433002/diff/1/src/codec/SkPngCodec.cpp#ne...
src/codec/SkPngCodec.cpp:180: return ((float) x) * 100000.0f;
I think you want 1.0f / (png_fixed_point_to_float(x)), which is not the same
thing.

[msarett, 2016-03-23 13:16:19]

https://codereview.chromium.org/1829433002/diff/1/src/codec/SkPngCodec.cpp
File src/codec/SkPngCodec.cpp (right):

https://codereview.chromium.org/1829433002/diff/1/src/codec/SkPngCodec.cpp#ne...
src/codec/SkPngCodec.cpp:180: return ((float) x) * 100000.0f;
On 2016/03/23 13:01:50, Brian Osman wrote:
> I think you want 1.0f / (png_fixed_point_to_float(x)), which is not the same
> thing.

Doh thanks.  Tough day for algebra yesterday.

[msarett, 2016-03-24 22:59:18]

msarett@google.com changed reviewers:
+ scroggo@google.com

[Brian Osman, 2016-03-30 18:40:06]

lgtm

[msarett1, 2016-03-30 18:47:06]

The CQ bit was checked by msarett@chromium.org

[commit-bot: I haz the power, 2016-03-30 18:47:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829433002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829433002/20001

[commit-bot: I haz the power, 2016-03-30 19:01:50]

Description was changed from

==========
Correct png inverse gAMA when parsing color space

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Correct png inverse gAMA when parsing color space

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/128245c61d56abcacdb152ad08038c5d9c919df0
==========

[commit-bot: I haz the power, 2016-03-30 19:01:51]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/128245c61d56abcacdb152ad08038c5d9c919df0