Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1829403004: mojom_types.mojom: Add |min_version| fields in a few more places. (Closed)

Created:
4 years, 9 months ago by rudominer
Modified:
4 years, 8 months ago
Reviewers:
azani_google, azani
CC:
vardhan, mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

mojom_types.mojom: Add |min_version| fields in a few more places. We add a |min_version| field to the following: - UnionField - EnumValue - MojomMethod We also add a |current_version| field to MojomInterface. Some details about the above: - Currently the code generators do not support the MinVersion feature for union fields or enum values. However there was some stub of support for this that I deleted from module.py in https://codereview.chromium.org/1824263002/ so it appears that the MinVersion feature is intended to eventually be supported for union fields and enum values. - The lack of a |min_version| field in MojomMethod was an oversight. This is needed and currently the old backend is parsing it from the "MinVersion" attribute. - The |current_version| field for MojomInterface is something that is currently being computed in the backend and so adding this field is part of the effort to move more computations to the frontend. Note that these new fields are not currently being populated or consumed. That will happen in a follow-up cl. We also throw in some unrelated cleanups to mojom_types.mojom: - Delete the unused |resolved_concrete_value| field from UserValueReference. - Delete the unused |min_version| field from DeclarationData. - Fix comments in several places. BUG=#713 Committed: https://chromium.googlesource.com/external/mojo/+/a33fe682700c1272dd908721c044c89f19905f91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -148 lines) Patch
M mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import2.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/math/math_calculator.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/examples/echo.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/rect.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/serialization_test_structs.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_enums.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_included_unions.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_structs.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_unions.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/validation_test_interfaces.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/regression_tests/regression_tests.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_factory.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_interfaces.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_service.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart View 26 chunks +84 lines, -56 lines 0 comments Download
M mojo/public/interfaces/bindings/mojom_types.mojom View 7 chunks +25 lines, -19 lines 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/generated/mojom_types_mojom.py View 6 chunks +11 lines, -9 lines 0 comments Download
M mojom/mojom_parser/generated/mojom_types/mojom_types.mojom.go View 24 chunks +60 lines, -42 lines 0 comments Download
M mojom/mojom_parser/serialization/serialization.go View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
rudominer
Alex, Vardhan ptal. Vardhan I am including you since this will impact your work on ...
4 years, 8 months ago (2016-03-28 17:03:02 UTC) #4
azani
lgtm
4 years, 8 months ago (2016-03-28 18:25:23 UTC) #5
rudominer
4 years, 8 months ago (2016-03-28 18:28:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
a33fe682700c1272dd908721c044c89f19905f91 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698