Add recipes to the depgraph command.

Add recipes to the depgraph command.

Example: https://drive.google.com/open?id=0B4xuvnLQBc7kcGdSem5PajdVaEk

BUG=

Committed: https://github.com/luci/recipes-py/commit/8ed08764d99a47631f716803848ed9ce2ac1a9a1

[martiniss, 2016-03-26 00:12:29]

Description was changed from

==========
Add recipes to the depgraph command.

BUG=
==========

to

==========
Add recipes to the depgraph command.

See https://x20web.corp.google.com/users/ma/martiniss/graph.pdf for example.

Could add the 'clank' filtering by name as command line args.

Wanted this as part of me trying to clean up the clank recipes.

BUG=
==========

[martiniss, 2016-03-26 00:12:41]

martiniss@chromium.org changed reviewers:
+ iannucci@chromium.org, phajdan.jr@chromium.org

[martiniss, 2016-03-26 00:12:42]

FYI. Hacked this up real quick.

[Paweł Hajdan Jr., 2016-03-30 09:21:58]

https://codereview.chromium.org/1829403003/diff/1/recipe_engine/depgraph.py
File recipe_engine/depgraph.py (right):

https://codereview.chromium.org/1829403003/diff/1/recipe_engine/depgraph.py#n...
recipe_engine/depgraph.py:34: edges.append(((True, mod.NAME), (True, dep)))
It's not clear what's the meaning of True here - could you add a comment what
each element of tuple means?

https://codereview.chromium.org/1829403003/diff/1/recipe_engine/depgraph.py#n...
recipe_engine/depgraph.py:40: if 'example' in recipe_name:
These are hacks. Can we just add command-line arguments allowing filtering
recipe names out?

https://codereview.chromium.org/1829403003/diff/1/recipe_engine/depgraph.py#n...
recipe_engine/depgraph.py:47: edges.append(((False, recipe_name), (True, dep)))
IMO recipes in the graph should be optional. I'd prefer the default to not
include recipes, but I don't have a strong opinion about that.

What I care about, is to add a command-line switch to allow including or
excluding recipes here.

https://codereview.chromium.org/1829403003/diff/1/recipe_engine/depgraph.py#n...
recipe_engine/depgraph.py:57: first_name = modulify(first_name)
Why do we need calls to modulify?

That's probably to avoid collisions, but then why don't we rather prefix
recipes? Most of the dependencies are actually between modules, and recipes only
have edges going out.

By the way, a possible idea may be for recipes to have a different shape on the
graph, and use a different display label than we use for linking graph nodes.

[martiniss, 2016-03-30 23:05:14]

PTAL; addressed most comments.

Done some more stuff, yay!

Example graph: https://drive.google.com/open?id=0B4xuvnLQBc7kcGdSem5PajdVaEk

This was made by doing recipes.py depgraph --ignore-package recipe_engine
--recipe-filter infra | tred | dot -Tpdf > graph.pdf

[martiniss, 2016-04-01 21:44:44]

Description was changed from

==========
Add recipes to the depgraph command.

See https://x20web.corp.google.com/users/ma/martiniss/graph.pdf for example.

Could add the 'clank' filtering by name as command line args.

Wanted this as part of me trying to clean up the clank recipes.

BUG=
==========

to

==========
Add recipes to the depgraph command.

Example: https://drive.google.com/open?id=0B4xuvnLQBc7kcGdSem5PajdVaEk

BUG=
==========

[iannucci, 2016-04-01 21:48:51]

lgtm

[martiniss, 2016-04-01 21:51:31]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-04-01 21:51:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829403003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829403003/60001

[commit-bot: I haz the power, 2016-04-01 21:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 21:53:46]

Try jobs failed on following builders:
  Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/...)

[martiniss, 2016-04-01 22:27:40]

The CQ bit was checked by martiniss@chromium.org

[martiniss, 2016-04-01 22:27:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1829403003/#ps80001
(title: "Lint")

[commit-bot: I haz the power, 2016-04-01 22:27:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829403003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829403003/80001

[commit-bot: I haz the power, 2016-04-01 22:28:55]

Description was changed from

==========
Add recipes to the depgraph command.

Example: https://drive.google.com/open?id=0B4xuvnLQBc7kcGdSem5PajdVaEk

BUG=
==========

to

==========
Add recipes to the depgraph command.

Example: https://drive.google.com/open?id=0B4xuvnLQBc7kcGdSem5PajdVaEk

BUG=

Committed:
https://github.com/luci/recipes-py/commit/8ed08764d99a47631f716803848ed9ce2ac...
==========

[commit-bot: I haz the power, 2016-04-01 22:28:56]

Committed patchset #5 (id:80001) as
https://github.com/luci/recipes-py/commit/8ed08764d99a47631f716803848ed9ce2ac...