Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/WebKit/Source/core/css/CSSFontSelector.cpp

Issue 1829403002: Clean up font loading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Resource_status
Patch Set: Address hiroshige's comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSFontSelector.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
index bdbf13add6a35b9f5409b2f5892401d5cf8f2784..3c3dd7b5bbbf535b551f70036ef91be38d1bd612 100644
--- a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
+++ b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
@@ -44,7 +44,6 @@ namespace blink {
CSSFontSelector::CSSFontSelector(Document* document)
: m_document(document)
- , m_fontLoader(FontLoader::create(this, document))
, m_genericFontFamilySettings(document->frame()->settings()->genericFontFamilySettings())
{
// FIXME: An old comment used to say there was no need to hold a reference to m_document
@@ -165,7 +164,6 @@ bool CSSFontSelector::isPlatformFontAvailable(const FontDescription& fontDescrip
#if !ENABLE(OILPAN)
void CSSFontSelector::clearDocument()
{
- m_fontLoader->clearDocumentAndFontSelector();
m_document = nullptr;
m_fontFaceCache.clearAll();
}
@@ -184,7 +182,6 @@ DEFINE_TRACE(CSSFontSelector)
visitor->trace(m_document);
visitor->trace(m_fontFaceCache);
visitor->trace(m_clients);
- visitor->trace(m_fontLoader);
FontSelector::trace(visitor);
}

Powered by Google App Engine
This is Rietveld 408576698