Add keyboard accessibility to ConstrainedWindowButton

chrome/browser/ui/cocoa/constrained_window/constrained_window_button.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_button.h"
 
+#import <Carbon/Carbon.h>  // kVK_Return.
+
 #include "base/mac/scoped_nsobject.h"
 #import "chrome/browser/ui/cocoa/key_equivalent_constants.h"
 #include "skia/ext/skia_utils_mac.h"
 #import "third_party/molokocacao/NSBezierPath+MCAdditions.h"
 #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h"
 
 @interface ConstrainedWindowButton ()
 - (BOOL)isMouseReallyInside;
 @end
 
@@ skipping 221 matching lines @@
 + (void)DrawBorderForPath:(NSBezierPath*)path
                  withCell:(id<ConstrainedWindowButtonDrawableCell>)cell
                    inView:(NSView*)view {
   if ([[[view window] firstResponder] isEqual:view])
     [[NSColor colorWithCalibratedRed:0.30 green:0.57 blue:1.0 alpha:1.0] set];
   else
     [GetButtonBorderColor(cellButtonState(cell)) set];
   [path stroke];
 }
 
+- (BOOL)canBecomeKeyView {
+  return YES;
+}
+
+- (void)keyDown:(NSEvent*)event {
+  // Since there is no default button in the bubble, it is safe to activate
+  // all buttons on Enter as well, and be consistent with the Windows
+  // implementation.
+  if ([event keyCode] == kVK_Return)

[Robert Sesek, 2016/03/25 20:16:03]

Return is not typically how buttons are invoked on OS X, it's usually space.
Does that work without this change to -keyDown:?

[juncai, 2016/03/25 20:31:54]

The space works without this change to -keyDown:. So this method is removed.

Done.

+    [self performClick:self];
+  else
+    [super keyDown:event];
+}
+
 @end
 
 @implementation ConstrainedWindowButtonCell
 
 @synthesize isMouseInside = isMouseInside_;
 
 - (void)drawBezelWithFrame:(NSRect)frame inView:(NSView*)controlView {
   // Inset to leave room for shadow.
   --frame.size.height;
 
@@ skipping 23 matching lines @@
   size.width += kButtonPaddingX * 2;
   return size;
 }
 
 - (NSAttributedString*)getAttributedTitle {
   return GetButtonAttributedString(
       [self title], [self keyEquivalent], self);
 }
 
 @end