Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 182933002: Fix build issues in net/ for Android x64 (Closed)

Created:
6 years, 9 months ago by Yang Gu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix build issues in net/ for Android x64 BUG=346626 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M net/android/java/src/org/chromium/net/AndroidKeyStore.java View 1 chunk +1 line, -1 line 0 comments Download
M net/android/java/src/org/chromium/net/DefaultAndroidKeyStore.java View 2 chunks +3 lines, -3 lines 0 comments Download
M net/android/java/src/org/chromium/net/RemoteAndroidKeyStore.java View 1 chunk +1 line, -1 line 0 comments Download
M net/android/keystore.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Yang Gu
6 years, 9 months ago (2014-02-27 09:53:40 UTC) #1
rmcilroy
lgtm Thanks!
6 years, 9 months ago (2014-02-27 11:54:43 UTC) #2
rmcilroy
On 2014/02/27 11:54:43, rmcilroy wrote: > lgtm > > Thanks! Again, you will need someone ...
6 years, 9 months ago (2014-02-27 11:55:04 UTC) #3
bulach
lgtm too but I'm not owner ;) +pliard for net/android OWNERS
6 years, 9 months ago (2014-02-27 15:38:52 UTC) #4
Philippe
lgtm, thanks!
6 years, 9 months ago (2014-02-27 15:56:07 UTC) #5
Yang Gu
The CQ bit was checked by yang.gu@intel.com
6 years, 9 months ago (2014-02-28 02:21:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yang.gu@intel.com/182933002/1
6 years, 9 months ago (2014-02-28 02:22:49 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 03:29:42 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=79988
6 years, 9 months ago (2014-02-28 03:29:42 UTC) #9
Yang Gu
The CQ bit was checked by yang.gu@intel.com
6 years, 9 months ago (2014-02-28 13:55:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yang.gu@intel.com/182933002/1
6 years, 9 months ago (2014-02-28 13:55:38 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 16:32:17 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=272086
6 years, 9 months ago (2014-02-28 16:32:18 UTC) #13
Yang Gu
The CQ bit was checked by yang.gu@intel.com
6 years, 9 months ago (2014-03-02 08:26:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yang.gu@intel.com/182933002/1
6 years, 9 months ago (2014-03-02 08:26:26 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-02 20:21:15 UTC) #16
Message was sent while issue was closed. 
Change committed as 254412

Powered by Google App Engine
This is Rietveld 408576698