src/effects/SkLayerDrawLooper.cpp - Issue 1829303002: move setshader to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLayerDrawLooper.cpp

Issue 1829303002: move setshader to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: addressing comments from #8 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLayerDrawLooper.cpp

diff --git a/src/effects/SkLayerDrawLooper.cpp b/src/effects/SkLayerDrawLooper.cpp

index 8510767801c174a401cf28b0a3fb31b157ee1bc6..526fb4d7e304d66d8533b8f571a21dfd6f591cb4 100644

--- a/src/effects/SkLayerDrawLooper.cpp

+++ b/src/effects/SkLayerDrawLooper.cpp

@@ -99,7 +99,7 @@ void SkLayerDrawLooper::LayerDrawLooperContext::ApplyInfo(

dst->setMaskFilter(src.getMaskFilter());

}

if (bits & kShader_Bit) {

- dst->setShader(src.getShader());

+ dst->setShader(sk_ref_sp(src.getShader()));

}

if (bits & kColorFilter_Bit) {

dst->setColorFilter(sk_ref_sp(src.getColorFilter()));

« no previous file with comments | « src/core/SkPaint.cpp ('k') | src/effects/SkPerlinNoiseShader.cpp » ('j') | no next file with comments »