src/animator/SkDrawPaint.cpp - Issue 1829303002: move setshader to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/animator/SkDrawPaint.cpp

Issue 1829303002: move setshader to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: addressing comments from #8 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/animator/SkDrawPaint.cpp

diff --git a/src/animator/SkDrawPaint.cpp b/src/animator/SkDrawPaint.cpp

index 5f6efd8cc9e6f7af6c9cea8553f6ce9857d7e55c..fc1a4132440da91ff0830027ae3a6f6b50030461 100644

--- a/src/animator/SkDrawPaint.cpp

+++ b/src/animator/SkDrawPaint.cpp

@@ -237,7 +237,7 @@ void SkDrawPaint::setupPaint(SkPaint* paint) const {

if (shader == nullptr)

paint->setShader(nullptr);

else if (shader != (SkDrawShader*) -1)

- SkSafeUnref(paint->setShader(shader->getShader()));

+ paint->setShader(sk_ref_sp(shader->getShader()));

if (strikeThru != -1)

paint->setStrikeThruText(SkToBool(strikeThru));

if (strokeCap != -1)

« no previous file with comments | « samplecode/SampleLighting.cpp ('k') | src/c/sk_paint.cpp » ('j') | no next file with comments »