Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2492)

Unified Diff: experimental/PdfViewer/pdf_viewer_main.cpp

Issue 18293012: pdf viewer: fix a few warnings, and enable warning as errors (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: experimental/PdfViewer/pdf_viewer_main.cpp
===================================================================
--- experimental/PdfViewer/pdf_viewer_main.cpp (revision 9961)
+++ experimental/PdfViewer/pdf_viewer_main.cpp (working copy)
@@ -48,6 +48,7 @@
* @returns false if the file did not has the expected extension.
* if false is returned, contents of path are undefined.
*/
+/*
static bool replace_filename_extension(SkString* path,
const char old_extension[],
const char new_extension[]) {
@@ -62,7 +63,7 @@
}
return false;
}
-
+*/
/** Builds the output filename. path = dir/name, and it replaces expected
* .skp extension with .pdf extention.
* @param path Output filename.
@@ -70,6 +71,8 @@
* @returns false if the file did not has the expected extension.
* if false is returned, contents of path are undefined.
*/
+
+/*
static bool make_output_filepath(SkString* path, const SkString& dir,
const SkString& name) {
sk_tools::make_filepath(path, dir, name);
@@ -77,12 +80,13 @@
PDF_FILE_EXTENSION,
PNG_FILE_EXTENSION);
}
-
+*/
/** Write the output of pdf renderer to a file.
* @param outputDir Output dir.
* @param inputFilename The skp file that was read.
* @param renderer The object responsible to write the pdf file.
*/
+/*
static bool write_output(const SkString& outputDir,
const SkString& inputFilename,
const SkPdfViewer& renderer) {
@@ -106,7 +110,7 @@
return true;
}
-
+*/
/** Reads an skp file, renders it to pdf and writes the output to a pdf file
* @param inputPath The skp file to be read.
* @param outputDir Output dir.
« no previous file with comments | « experimental/PdfViewer/SkPdfParser.cpp ('k') | experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698