Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Unified Diff: experimental/PdfViewer/SkPdfFont.h

Issue 18293012: pdf viewer: fix a few warnings, and enable warning as errors (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | experimental/PdfViewer/SkPdfFont.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: experimental/PdfViewer/SkPdfFont.h
===================================================================
--- experimental/PdfViewer/SkPdfFont.h (revision 9962)
+++ experimental/PdfViewer/SkPdfFont.h (working copy)
@@ -20,11 +20,20 @@
class SkPdfMultiMasterFont;
class SkPdfFont;
-
struct SkPdfStandardFontEntry {
+ // We don't own this pointer!
const char* fName;
bool fIsBold;
bool fIsItalic;
+ SkPdfStandardFontEntry()
+ : fName(NULL),
+ fIsBold(false),
+ fIsItalic(false) {}
+
+ SkPdfStandardFontEntry(const char* name, bool bold, bool italic)
+ : fName(name),
+ fIsBold(bold),
+ fIsItalic(italic) {}
};
std::map<std::string, SkPdfStandardFontEntry>& getStandardFonts();
« no previous file with comments | « no previous file | experimental/PdfViewer/SkPdfFont.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698