Enable IO before reading /proc/self/maps.

base/debug/stack_trace_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/stack_trace.h"
 
 #include <android/log.h>
 #include <unwind.h>  // TODO(dmikurube): Remove.  See http://crbug.com/236855.
 
 #include "base/debug/proc_maps_linux.h"
 #include "base/strings/stringprintf.h"
+#include "base/threading/thread_restrictions.h"
 
 // TODO(dmikurube): Remove when Bionic's get_backtrace() gets popular.
 // See http://crbug.com/236855.
 namespace {
 
 /* depends how the system includes define this */
 #ifdef HAVE_UNWIND_CONTEXT_STRUCT
 typedef struct _Unwind_Context __unwind_context;
 #else
 typedef _Unwind_Context __unwind_context;
@@ skipping 69 matching lines @@
   std::string backtrace = ToString();
   __android_log_write(ANDROID_LOG_ERROR, "chromium", backtrace.c_str());
 }
 
 // NOTE: Native libraries in APKs are stripped before installing. Print out the
 // relocatable address and library names so host computers can use tools to
 // symbolize and demangle (e.g., addr2line, c++filt).
 void StackTrace::OutputToStream(std::ostream* os) const {
   std::string proc_maps;
   std::vector<MappedMemoryRegion> regions;
+  // Allow IO to read /proc/self/maps. Reading this file doesn't hit the disk
+  // since it lives in procfs, and this is currently used to print a stack trace
+  // on fatal log messages in debug builds only. If the restriction is enabled
+  // then it will recursively trigger fatal failures when this enters on the
+  // UI thread.
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   if (!ReadProcMaps(&proc_maps)) {

[scherkus (not reviewing), 2013/07/10 15:35:30]

Q: thoughts on putting the ScopedAllowIO inside ReadProcMaps() itself?

[Joao da Silva, 2013/07/10 15:36:44]

Seems like a better place for this to me. Mark, what do you think?

     __android_log_write(
         ANDROID_LOG_ERROR, "chromium", "Failed to read /proc/self/maps");
   } else if (!ParseProcMaps(proc_maps, &regions)) {
     __android_log_write(
         ANDROID_LOG_ERROR, "chromium", "Failed to parse /proc/self/maps");
   }
 
   for (size_t i = 0; i < count_; ++i) {
     // Subtract one as return address of function may be in the next
     // function when a function is annotated as noreturn.
@@ skipping 17 matching lines @@
     } else {
       *os << "<unknown>";
     }
 
     *os << "\n";
   }
 }
 
 }  // namespace debug
 }  // namespace base