Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1829293002: Make the test NPAPI plugin not handle png (Closed)

Created:
4 years, 9 months ago by piman
Modified:
4 years, 9 months ago
Reviewers:
dcheng
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the test NPAPI plugin not handle png This is not a feature we have/need in PPAPI BUG=493212 Committed: https://crrev.com/af5d661c72f723eebb145b9df57dddc745d059c7 Cr-Commit-Position: refs/heads/master@{#383437}

Patch Set 1 #

Patch Set 2 : test2 #

Patch Set 3 : rebase; request rebaseline on linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M content/shell/tools/plugin/mac/Info.plist View 1 chunk +0 lines, -9 lines 0 comments Download
M content/shell/tools/plugin/main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/plugin/win/TestNetscapePlugin.rc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/block/float/4145535Crash.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/replaced/replaced-breaking.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
piman
WDYT? In theory, an <embed> can handle image types in 2 ways: 1- if a ...
4 years, 9 months ago (2016-03-25 21:46:12 UTC) #2
dcheng
lgtm
4 years, 9 months ago (2016-03-25 22:10:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829293002/20001
4 years, 9 months ago (2016-03-25 22:17:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/21958)
4 years, 9 months ago (2016-03-25 23:28:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829293002/40001
4 years, 9 months ago (2016-03-26 00:48:53 UTC) #10
piman
FYI, requesting rebaseline on linux for those 2 tests that I touched. I was wondering ...
4 years, 9 months ago (2016-03-26 00:50:34 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-26 02:21:47 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-26 02:23:14 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/af5d661c72f723eebb145b9df57dddc745d059c7
Cr-Commit-Position: refs/heads/master@{#383437}

Powered by Google App Engine
This is Rietveld 408576698