Issue 18292010: Merge 209839 "Don't mess with omnibox selection on update when t..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18292010: Merge 209839 "Don't mess with omnibox selection on update when t..." (Closed)

Created:
7 years, 5 months ago by Peter Kasting

Modified:
7 years, 5 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, tfarina, James Su

Base URL:
svn://svn.chromium.org/chrome/branches/1547/src/

Visibility:
Public.

Merge 209839 "Don't mess with omnibox selection on update when t..." > Don't mess with omnibox selection on update when the omnibox doesn't have focus. > This fixes a regression in selection behavior when navigating from the NTP. > > BUG=247933 > TEST=Visit NTP, click a tile, URL should not be selected > R=msw@chromium.org > > Review URL: https://codereview.chromium.org/18543012 TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210455

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -6 lines)			Patch
	M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View		1 chunk	+9 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/views/omnibox/omnibox_view_win.cc	View		1 chunk	+11 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r210455.