Inline native setters for length and data in the optimizer.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/flow_graph_compiler.h"
@@ skipping 1659 matching lines @@
     // No type feedback collected or multiple targets found.
     return false;
   }
 
   Function& target = Function::Handle();
   GrowableArray<intptr_t> class_ids;
   ic_data.GetCheckAt(0, &class_ids, &target);
   MethodRecognizer::Kind recognized_kind =
       MethodRecognizer::RecognizeKind(target);
 
+  if (recognized_kind == MethodRecognizer::kGrowableArraySetData &&
+      (ic_data.NumberOfChecks() == 1) &&
+      class_ids[0] == kGrowableObjectArrayCid) {

[srdjan, 2013/07/08 16:19:06]

Add parentheses

[Florian Schneider, 2013/07/08 16:24:58]

Done.

+    // This is an internal method, no need to check argument types.
+    Definition* array = call->ArgumentAt(0);
+    Definition* value = call->ArgumentAt(1);
+    StoreVMFieldInstr* store = new StoreVMFieldInstr(
+        new Value(array),
+        GrowableObjectArray::data_offset(),
+        new Value(value),
+        Type::ZoneHandle());
+    ReplaceCall(call, store);
+    return true;
+  }
+
+  if (recognized_kind == MethodRecognizer::kGrowableArraySetLength &&
+      (ic_data.NumberOfChecks() == 1) &&
+      class_ids[0] == kGrowableObjectArrayCid) {
+    // This is an internal method, no need to check argument types nor
+    // range.
+    Definition* array = call->ArgumentAt(0);
+    Definition* value = call->ArgumentAt(1);
+    StoreVMFieldInstr* store = new StoreVMFieldInstr(
+        new Value(array),
+        GrowableObjectArray::length_offset(),
+        new Value(value),
+        Type::ZoneHandle());
+    ReplaceCall(call, store);
+    return true;
+  }
+
   if ((recognized_kind == MethodRecognizer::kStringBaseCodeUnitAt) &&
       (ic_data.NumberOfChecks() == 1) &&
       ((class_ids[0] == kOneByteStringCid) ||
        (class_ids[0] == kTwoByteStringCid))) {
     LoadIndexedInstr* instr = BuildStringCodeUnitAt(call, class_ids[0]);
     ReplaceCall(call, instr);
     return true;
   }
   if ((class_ids[0] == kOneByteStringCid) && (ic_data.NumberOfChecks() == 1)) {
     if (recognized_kind == MethodRecognizer::kStringBaseCharAt) {
@@ skipping 5439 matching lines @@
 
   // Insert materializations at environment uses.
   const Class& cls = Class::Handle(alloc->constructor().Owner());
   for (intptr_t i = 0; i < exits.length(); i++) {
     CreateMaterializationAt(exits[i], alloc, cls, *fields);
   }
 }
 
 
 }  // namespace dart