Request frame for new sinks from MediaStreamVideoTrack

Request frame for new sinks from MediaStreamVideoTrack

This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added.
MediaStreamVideoTrack
-> MediaStreamVideoCapturerSource which is a MediaStreamVideoSource
-> media::VideoCapturerSource

This addresses the issues when a new sink is added but doesn't
receive a frame because it wasn't added on time.

BUG=597876, 587789, 486274
Committed: https://crrev.com/dbe511aa9eea169722b239f82174850df2185eff
Cr-Commit-Position: refs/heads/master@{#383421}

[emircan, 2016-03-24 21:34:55]

Description was changed from

==========
hold onto last.

BUG=
==========

to

==========
Hold onto last frame for bursting MediaStreamVideoSource

BUG=
==========

[emircan, 2016-03-24 21:41:20]

Patchset #1 (id:1) has been deleted

[emircan, 2016-03-24 23:38:55]

Patchset #2 (id:40001) has been deleted

[emircan, 2016-03-25 00:14:02]

Patchset #2 (id:60001) has been deleted

[emircan, 2016-03-25 00:18:18]

Description was changed from

==========
Hold onto last frame for bursting MediaStreamVideoSource

BUG=
==========

to

==========
Request frame for new sinks from MediaStreamVideoTrack

This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added. 
MediaStreamVideoTrack asks
-> MediaStreamVideoCapturerSource is a MediaStreamVideoSource
-> media::VideoCapturerSource

This addresses the issues when a new sink is added but doesn't 
receive a frame because it wasn't added on time. 

BUG=592396
==========

[emircan, 2016-03-25 00:19:00]

emircan@chromium.org changed reviewers:
+ mcasas@chromium.org, miu@chromium.org, philipj@opera.com

[emircan, 2016-03-25 00:19:01]

PTAL.

[emircan, 2016-03-25 01:35:02]

Description was changed from

==========
Request frame for new sinks from MediaStreamVideoTrack

This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added. 
MediaStreamVideoTrack asks
-> MediaStreamVideoCapturerSource is a MediaStreamVideoSource
-> media::VideoCapturerSource

This addresses the issues when a new sink is added but doesn't 
receive a frame because it wasn't added on time. 

BUG=592396
==========

to

==========
Request frame for new sinks from MediaStreamVideoTrack

This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added. 
MediaStreamVideoTrack asks
-> MediaStreamVideoCapturerSource is a MediaStreamVideoSource
-> media::VideoCapturerSource

This addresses the issues when a new sink is added but doesn't 
receive a frame because it wasn't added on time. 

BUG=597876, 592396,486274
==========

[emircan, 2016-03-25 01:52:46]

Patchset #2 (id:80001) has been deleted

[emircan, 2016-03-25 02:17:07]

Description was changed from

==========
Request frame for new sinks from MediaStreamVideoTrack

This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added. 
MediaStreamVideoTrack asks
-> MediaStreamVideoCapturerSource is a MediaStreamVideoSource
-> media::VideoCapturerSource

This addresses the issues when a new sink is added but doesn't 
receive a frame because it wasn't added on time. 

BUG=597876, 592396,486274
==========

to

==========
Request frame for new sinks from MediaStreamVideoTrack

This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added. 
MediaStreamVideoTrack 
-> MediaStreamVideoCapturerSource which is a MediaStreamVideoSource
-> media::VideoCapturerSource

This addresses the issues when a new sink is added but doesn't 
receive a frame because it wasn't added on time. 

BUG=597876, 592396,486274
==========

[miu, 2016-03-25 22:05:06]

https://codereview.chromium.org/1829193003/diff/100001/media/base/video_captu...
File media/base/video_capturer_source.h (right):

https://codereview.chromium.org/1829193003/diff/100001/media/base/video_captu...
media/base/video_capturer_source.h:82: virtual void RequestFrame() {}
1. Can we name this RequestRefreshFrame() here and in
MediaStreamVideoCapturerSource and MediaStreamVideoSource?  This would make it
consistent with the naming in the browser-side changes:
https://code.google.com/p/chromium/codesearch#chromium/src/media/capture/vide...

2. Also, this comment should probably describe the same semantics and usage
patterns as in the VideoCaptureDevice change (link above).  Meaning, the source
can decide whether to honor the request, depending on whether it will be sending
more frames soon or capture is halted due to unchanging content.

[emircan, 2016-03-25 23:18:41]

https://codereview.chromium.org/1829193003/diff/100001/media/base/video_captu...
File media/base/video_capturer_source.h (right):

https://codereview.chromium.org/1829193003/diff/100001/media/base/video_captu...
media/base/video_capturer_source.h:82: virtual void RequestFrame() {}
1) Done. I was trying to be consistent with RequestFrame() from the W3C spec[0],
but there are multiple users now :)

[0] http://w3c.github.io/mediacapture-fromelement/#dfn-requestframe

2) Done.

[miu, 2016-03-25 23:22:24]

lgtm

https://codereview.chromium.org/1829193003/diff/120001/media/base/video_captu...
File media/base/video_capturer_source.h (right):

https://codereview.chromium.org/1829193003/diff/120001/media/base/video_captu...
media/base/video_capturer_source.h:80: // a continuous rate of new frames(e.g.
canvas capture, screen capture where
nit: Please add a space before open-parenthesis.

[emircan, 2016-03-25 23:34:16]

Thanks.

https://codereview.chromium.org/1829193003/diff/120001/media/base/video_captu...
File media/base/video_capturer_source.h (right):

https://codereview.chromium.org/1829193003/diff/120001/media/base/video_captu...
media/base/video_capturer_source.h:80: // a continuous rate of new frames(e.g.
canvas capture, screen capture where
On 2016/03/25 23:22:24, miu wrote:
> nit: Please add a space before open-parenthesis.

Done.

[emircan, 2016-03-25 23:35:12]

emircan@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[emircan, 2016-03-25 23:35:12]

Adding dalecurtis@ for OWNERS review.

[emircan, 2016-03-25 23:36:08]

Description was changed from

==========
Request frame for new sinks from MediaStreamVideoTrack

This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added. 
MediaStreamVideoTrack 
-> MediaStreamVideoCapturerSource which is a MediaStreamVideoSource
-> media::VideoCapturerSource

This addresses the issues when a new sink is added but doesn't 
receive a frame because it wasn't added on time. 

BUG=597876, 592396,486274
==========

to

==========
Request frame for new sinks from MediaStreamVideoTrack

This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added. 
MediaStreamVideoTrack 
-> MediaStreamVideoCapturerSource which is a MediaStreamVideoSource
-> media::VideoCapturerSource

This addresses the issues when a new sink is added but doesn't 
receive a frame because it wasn't added on time. 

BUG=597876, 587789, 486274
==========

[DaleCurtis, 2016-03-25 23:40:06]

rs lgtm

[emircan, 2016-03-26 00:35:14]

The CQ bit was checked by emircan@chromium.org

[emircan, 2016-03-26 00:35:15]

The patchset sent to the CQ was uploaded after l-g-t-m from miu@chromium.org
Link to the patchset: https://codereview.chromium.org/1829193003/#ps140001
(title: "miu@ nit.")

[commit-bot: I haz the power, 2016-03-26 00:35:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829193003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829193003/140001

[commit-bot: I haz the power, 2016-03-26 00:46:11]

Description was changed from

==========
Request frame for new sinks from MediaStreamVideoTrack

This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added. 
MediaStreamVideoTrack 
-> MediaStreamVideoCapturerSource which is a MediaStreamVideoSource
-> media::VideoCapturerSource

This addresses the issues when a new sink is added but doesn't 
receive a frame because it wasn't added on time. 

BUG=597876, 587789, 486274
==========

to

==========
Request frame for new sinks from MediaStreamVideoTrack

This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added. 
MediaStreamVideoTrack 
-> MediaStreamVideoCapturerSource which is a MediaStreamVideoSource
-> media::VideoCapturerSource

This addresses the issues when a new sink is added but doesn't 
receive a frame because it wasn't added on time. 

BUG=597876, 587789, 486274
==========

[commit-bot: I haz the power, 2016-03-26 00:46:12]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-03-26 00:47:03]

Description was changed from

==========
Request frame for new sinks from MediaStreamVideoTrack

This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added. 
MediaStreamVideoTrack 
-> MediaStreamVideoCapturerSource which is a MediaStreamVideoSource
-> media::VideoCapturerSource

This addresses the issues when a new sink is added but doesn't 
receive a frame because it wasn't added on time. 

BUG=597876, 587789, 486274
==========

to

==========
Request frame for new sinks from MediaStreamVideoTrack

This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added.
MediaStreamVideoTrack
-> MediaStreamVideoCapturerSource which is a MediaStreamVideoSource
-> media::VideoCapturerSource

This addresses the issues when a new sink is added but doesn't
receive a frame because it wasn't added on time.

BUG=597876, 587789, 486274

Committed: https://crrev.com/dbe511aa9eea169722b239f82174850df2185eff
Cr-Commit-Position: refs/heads/master@{#383421}
==========

[commit-bot: I haz the power, 2016-03-26 00:47:04]

Patchset 4 (id:??) landed as
https://crrev.com/dbe511aa9eea169722b239f82174850df2185eff
Cr-Commit-Position: refs/heads/master@{#383421}

[philipj_slow, 2016-03-29 08:48:51]

Is there an issue to make the matching change to the spec? If this CL does what
I think it does, it's the opposite of how I thought
https://github.com/w3c/mediacapture-fromelement/issues/29 was going to be
resolved.