Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: media/blink/multibuffer.h

Issue 1829163002: Lazily prune the multibuffer block cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: no export Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/fake_single_thread_task_runner.cc ('k') | media/blink/multibuffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/multibuffer.h
diff --git a/media/blink/multibuffer.h b/media/blink/multibuffer.h
index cecca4a2c2f988328607a4a26def8620bec9a91f..f3525f7bd4d4fcd29bf130f698c647a1013c8765 100644
--- a/media/blink/multibuffer.h
+++ b/media/blink/multibuffer.h
@@ -19,6 +19,7 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
+#include "base/single_thread_task_runner.h"
#include "build/build_config.h"
#include "media/base/data_buffer.h"
#include "media/blink/interval_map.h"
@@ -130,14 +131,26 @@ class MEDIA_BLINK_EXPORT MultiBuffer {
class MEDIA_BLINK_EXPORT GlobalLRU : public base::RefCounted<GlobalLRU> {
public:
typedef MultiBufferGlobalBlockId GlobalBlockId;
- GlobalLRU();
+ explicit GlobalLRU(
+ const scoped_refptr<base::SingleThreadTaskRunner>& task_runner);
// Free elements from cache if needed and possible.
// Don't free more than |max_to_free| blocks.
// Virtual for testing purposes.
void Prune(int64_t max_to_free);
+ // Returns true if there are prunable blocks.
+ bool Pruneable() const;
+
+ // Incremnt the amount of data used by all multibuffers.
void IncrementDataSize(int64_t blocks);
+
+ // Each multibuffer is allowed a certain amount of memory,
+ // that memory is registered by calling this function.
+ // The memory is actually shared by all multibuffers.
+ // When the total amount of memory used by all multibuffers
+ // is greater than what has been registered here, we use the
+ // LRU to decide what blocks to free first.
void IncrementMaxSize(int64_t blocks);
// LRU operations.
@@ -151,15 +164,29 @@ class MEDIA_BLINK_EXPORT MultiBuffer {
friend class base::RefCounted<GlobalLRU>;
~GlobalLRU();
+ // Schedule background pruning, if needed.
+ void SchedulePrune();
+
+ // Perform background pruning.
+ void PruneTask();
+
// Max number of blocks.
int64_t max_size_;
// Sum of all multibuffer::data_.size().
int64_t data_size_;
+ // True if there is a call to the background pruning outstanding.
+ bool background_pruning_pending_;
+
// The LRU should contain all blocks which are not pinned from
// all multibuffers.
LRU<GlobalBlockId> lru_;
+
+ // Where we run our tasks.
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
+
+ DISALLOW_COPY_AND_ASSIGN(GlobalLRU);
};
MultiBuffer(int32_t block_size_shift,
« no previous file with comments | « media/base/fake_single_thread_task_runner.cc ('k') | media/blink/multibuffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698